Hide the stem analyzer setting

mixxxdj · Jul 13, 2024 · 711af7f · 711af7f
1 parent 1a090a4
commit 711af7f
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 5 deletions.
diff --git a/src/preferences/beatdetectionsettings.h b/src/preferences/beatdetectionsettings.h
@@ -22,11 +22,11 @@
 class BeatDetectionSettings {
   public:
     enum class StemStrategy {
-        Disabled,
-        // TODO (xxx) - detect if the stem is using compliant labels for its
+        Disabled = 0,
+        // TODO (#13466) - detect if the stem is using compliant labels for its
         // channels and use the first channel if so - to be implemented
         // Automatic
-        Enforced
+        Enforced = 2
     };
 
     BeatDetectionSettings(UserSettingsPointer pConfig) : m_pConfig(pConfig) {}

diff --git a/src/preferences/dialog/dlgprefbeats.cpp b/src/preferences/dialog/dlgprefbeats.cpp
@@ -22,6 +22,10 @@ DlgPrefBeats::DlgPrefBeats(QWidget* parent, UserSettingsPointer pConfig)
 
     loadSettings();
 
+    // TODO (#13466) Keeping the setting hidden for now
+    comboBoxStemStrategy->hide();
+    labelStemStrategy->hide();
+
     // Connections
     connect(comboBoxBeatPlugin,
             QOverload<int>::of(&QComboBox::currentIndexChanged),

diff --git a/src/preferences/dialog/dlgprefbeatsdlg.ui b/src/preferences/dialog/dlgprefbeatsdlg.ui
@@ -89,7 +89,7 @@ This can speed up beat detection on slower computers but may result in lower qua
       <item>
        <layout class="QHBoxLayout" name="horizontalLayout_2">
         <item>
-         <widget class="QLabel" name="label">
+         <widget class="QLabel" name="labelStemStrategy">
           <property name="text">
            <string>Use rhythmic channel when analysing stem file</string>
           </property>

diff --git a/src/preferences/dialog/dlgprefkey.cpp b/src/preferences/dialog/dlgprefkey.cpp
@@ -50,6 +50,10 @@ DlgPrefKey::DlgPrefKey(QWidget* parent, UserSettingsPointer pConfig)
 
     loadSettings();
 
+    // TODO (#13466) Keeping the setting hidden for now
+    comboBoxStemStrategy->hide();
+    labelStemStrategy->hide();
+
     // Connections
     connect(plugincombo, QOverload<int>::of(&QComboBox::currentIndexChanged),
             this, &DlgPrefKey::pluginSelected);

diff --git a/src/preferences/dialog/dlgprefkeydlg.ui b/src/preferences/dialog/dlgprefkeydlg.ui
@@ -82,7 +82,7 @@ and allows you to pitch adjust them for harmonic mixing.</string>
       <item>
        <layout class="QHBoxLayout" name="horizontalLayout_2">
         <item>
-         <widget class="QLabel" name="label">
+         <widget class="QLabel" name="labelStemStrategy">
           <property name="text">
            <string>Exclude rhythmic channel when analysing stem file</string>
           </property>