Merge pull request #12051 from fwcd/fix-ui-key

WKey: Fix regression in key notation change
mixxxdj · Oct 3, 2023 · 790ec2a · 790ec2a
2 parents 300dc0b + 16ba8bd
commit 790ec2a
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/widget/wkey.cpp b/src/widget/wkey.cpp
@@ -62,6 +62,8 @@ void WKey::setCents() {
     setValue(m_dOldValue);
 }
 
-void WKey::keyNotationChanged(double dValue) {
-    setValue(dValue);
+void WKey::keyNotationChanged(double dKeyNotationValue) {
+    // NOTE: dKeyNotationValue is the index of the key notation type, NOT the
+    // key itself, so we intentionally set the old value again to update the UI.
+    setValue(m_dOldValue);
 }