effect parameters: fix/remove various neutral-point-on-scale values

mixxxdj · Apr 22, 2024 · 8ae5bff · 8ae5bff
1 parent 7b5d302
commit 8ae5bff
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/src/effects/backends/builtin/graphiceqeffect.cpp b/src/effects/backends/builtin/graphiceqeffect.cpp
@@ -66,6 +66,7 @@ EffectManifestPointer GraphicEQEffect::getManifest() {
             "Gain for High Filter"));
     high->setValueScaler(EffectManifestParameter::ValueScaler::Linear);
     high->setUnitsHint(EffectManifestParameter::UnitsHint::Unknown);
+    high->setNeutralPointOnScale(0.5);
     high->setRange(-12, 0, 12);
 
     return pManifest;

diff --git a/src/effects/backends/builtin/parametriceqeffect.cpp b/src/effects/backends/builtin/parametriceqeffect.cpp
@@ -60,7 +60,6 @@ EffectManifestPointer ParametricEQEffect::getManifest() {
             "Center frequency for Filter 1, from 100 Hz to 14 kHz"));
     center1->setValueScaler(EffectManifestParameter::ValueScaler::Logarithmic);
     center1->setUnitsHint(EffectManifestParameter::UnitsHint::Hertz);
-    center1->setNeutralPointOnScale(0.5);
     center1->setRange(100, kDefaultCenter1, 14000);
 
     EffectManifestParameterPointer gain2 = pManifest->addParameter();
@@ -95,7 +94,6 @@ EffectManifestPointer ParametricEQEffect::getManifest() {
             "Center frequency for Filter 2, from 100 Hz to 14 kHz"));
     center2->setValueScaler(EffectManifestParameter::ValueScaler::Logarithmic);
     center2->setUnitsHint(EffectManifestParameter::UnitsHint::Hertz);
-    center2->setNeutralPointOnScale(0.5);
     center2->setRange(100, kDefaultCenter2, 14000);
 
     return pManifest;

diff --git a/src/effects/backends/builtin/pitchshifteffect.cpp b/src/effects/backends/builtin/pitchshifteffect.cpp
@@ -80,7 +80,7 @@ EffectManifestPointer PitchShiftEffect::getManifest() {
             "The pitch shift applied to the sound."));
     pitch->setValueScaler(EffectManifestParameter::ValueScaler::Linear);
     pitch->setDefaultLinkType(EffectManifestParameter::LinkType::Linked);
-    pitch->setNeutralPointOnScale(0.0);
+    pitch->setNeutralPointOnScale(0.5);
     pitch->setRange(-1.0, 0.0, 1.0);
 
     EffectManifestParameterPointer range = pManifest->addParameter();
@@ -91,7 +91,7 @@ EffectManifestPointer PitchShiftEffect::getManifest() {
             "The range of the Pitch knob (0 - 2 octaves).\n"));
     range->setValueScaler(EffectManifestParameter::ValueScaler::Linear);
     range->setDefaultLinkType(EffectManifestParameter::LinkType::Linked);
-    range->setNeutralPointOnScale(1.0);
+    range->setNeutralPointOnScale(0.5);
     range->setRange(0.0, 1.0, 2.0);
 
     EffectManifestParameterPointer semitonesMode = pManifest->addParameter();