Replace DEBUG_ASSERT(false) with an inverted string literal

mixxxdj · Aug 21, 2021 · e124d1a · e124d1a
1 parent 5080d9f
commit e124d1a
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/src/control/control.cpp b/src/control/control.cpp
@@ -153,7 +153,7 @@ QSharedPointer<ControlDoublePrivate> ControlDoublePrivate::getControl(
                             << "ControlObject"
                             << key.group << key.item
                             << "already created";
-                    DEBUG_ASSERT(false);
+                    DEBUG_ASSERT(!"pCreatorCO != nullptr, ControlObject already created");
                     return nullptr;
                 }
                 return pControl;
@@ -313,8 +313,8 @@ double ControlDoublePrivate::getParameterForValue(double value) const {
 double ControlDoublePrivate::getParameterForMidi(double midiParam) const {
     QSharedPointer<ControlNumericBehavior> pBehavior = m_pBehavior;
     if (!pBehavior) {
-        qWarning() << "Cannot set" << m_key << "by Midi";
-        DEBUG_ASSERT(false);
+        qWarning() << "Cannot get" << m_key << "for Midi";
+        DEBUG_ASSERT(!"pBehavior == nullptr, getParameterForMidi is returning 0");
         return 0;
     }
     return pBehavior->midiToParameter(midiParam);
@@ -323,8 +323,8 @@ double ControlDoublePrivate::getParameterForMidi(double midiParam) const {
 void ControlDoublePrivate::setValueFromMidi(MidiOpCode opcode, double midiParam) {
     QSharedPointer<ControlNumericBehavior> pBehavior = m_pBehavior;
     if (!pBehavior) {
-        qWarning() << "Cannot set" << m_key << "by Midi";
-        DEBUG_ASSERT(false);
+        qWarning() << "Cannot set" << m_key << "from Midi";
+        DEBUG_ASSERT(!"pBehavior == nullptr, abort setValueFromMidi()");
         return;
     }
     pBehavior->setValueFromMidi(opcode, midiParam, this);
@@ -333,8 +333,8 @@ void ControlDoublePrivate::setValueFromMidi(MidiOpCode opcode, double midiParam)
 double ControlDoublePrivate::getMidiParameter() const {
     QSharedPointer<ControlNumericBehavior> pBehavior = m_pBehavior;
     if (!pBehavior) {
-        qWarning() << "Cannot get" << m_key << "by Midi";
-        DEBUG_ASSERT(false);
+        qWarning() << "Cannot get" << m_key << "as Midi";
+        DEBUG_ASSERT(!"pBehavior == nullptr, getMidiParameter() is returning 0");
         return 0;
     }
     return pBehavior->valueToMidiParameter(get());