Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "Cover Art"column to "Art" #10012

Closed
mixxxbot opened this issue Aug 23, 2022 · 7 comments
Closed

Rename "Cover Art"column to "Art" #10012

mixxxbot opened this issue Aug 23, 2022 · 7 comments

Comments

@mixxxbot
Copy link
Collaborator

Reported by: JoergAtGithub
Date: 2020-06-09T18:35:03Z
Status: New
Importance: Undecided
Launchpad Issue: lp1882829
Attachments: CoverArt_Header_with_SquareCoverArt.PNG


If I adjust the width of the "Cover Art" column to the be equal to the height, that I see the full cover, the text of the column header is truncated to "Cov", because there's only enough space to show 3 characters left. This could be solved by renaming the Column to "Art".

@mixxxbot
Copy link
Collaborator Author

Commented by: JoergAtGithub
Date: 2020-06-09T18:35:03Z
Attachments: CoverArt_Header_with_SquareCoverArt.PNG

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2020-06-09T19:53:18Z


Cov is not too bad.
Remember that we need to solve the issue for every translation of Cover Art.

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2020-06-09T20:02:24Z


I am not a native speaker, but "Art" is too short and generic. The minimum would be "Artwork" which is commonly used and would then be truncated to "Art...".

@mixxxbot
Copy link
Collaborator Author

Commented by: mxmilkiib
Date: 2020-12-05T18:53:54Z


Currently the column is titled "Show Cover Art" which doesn't sound right.

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2020-12-06T20:16:32Z


@mxmilkiib I guess you're confusing the Cover Art column with View > Show Cover Art which toggles the independet cover art widget for selected tracks.
(that has another bug, see lp:1906997)

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2020-12-06T20:33:21Z


btw I think the issue described here is not really relevant, or put another way I doubt we can achieve the optimum column title because it depends on multiple factors:

  • the font-size of the the column headers is currently hard-coded per skin (which isn't really optimal because it doesn't adapt to the library font size and libray row height)
  • users can set the library font size and libray row height individually which would then also give a different Cover column width (IF users want a square cover art)
  • do users want a square cover art? for example I like a 2:1 aspect ratio (width:height) because 1:1 is too small with my font settings to recognise the picture

Besides toggling the cover column from the header context menu, what value does the title have anyway? For text columns the title is necessary to distinguish artist and album artist columns for example, but the cover column is the only column with pictures so I think any distinct title would work, regardless to what it 'probably' is truncated to.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@daschuer
Copy link
Member

We have also the issue that we can't control the length of the translated texts. Let's close this for now. Please reopen if we have missed an aspect.

@daschuer daschuer closed this as not planned Won't fix, can't repro, duplicate, stale Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants