Search bar focuses when maximizing library

[mixxxbot]

Reported by: Holzhaus
Date: 2021-07-20T10:49:09Z
Status: Fix Released
Importance: High
Launchpad Issue: lp1936926

---

Found on main branch, didn't check 2.3.

Steps to reproduce:

1. Click the waveform to scratch
2. Press Spacebar to maximize the library
3. Press Spacebar again
   • Expected: The library unmaximizes
   • Actual: The search box received the focus after step 2, so a space is entered in the search box instead.

Possibly related past bugs:

• https://bugs.launchpad.net/bugs/1462061
• https://bugs.launchpad.net/bugs/1815314
• https://bugs.launchpad.net/bugs/1886661

[mixxxbot]

Commented by: ronso0
Date: 2021-07-20T11:36:13Z

---

in all skins except Shade the library is in a widget stack. switching widget inside that should restore the previously focused widget.
so the bug is that somehow the waveform viewer can be focused (or at least the tracks table loses focus) and that focus can not be restored when the waveforms are hidden, then the next posible widget is focused (search bar).

This can be fixed with explicitely setting the focus policy of the wwaveformviewer to 'nofocus' like we do for other widgets.

[mixxxbot]

Commented by: ronso0
Date: 2021-07-20T11:37:30Z

---

#4128

[mixxxbot]

Commented by: ronso0
Date: 2021-07-20T11:39:28Z

---

2.3 is also affected but the sidebar is auto-focused there, so minimizing the library still works.

[mixxxbot]

Commented by: ronso0
Date: 2021-07-23T18:56:39Z

---

and for 2.3
#4134

[mixxxbot]

Issue closed with status Fix Released.