New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mixxx uses german language on macOS despite system language set to english #11195

Closed

foss- opened this issue Jan 10, 2023 · 6 comments

Labels

bug

Contributor

foss- commented Jan 10, 2023 •

edited

Bug Description

Mixxx 2.4-alpha-1398-g9c4e2f1d1a (main)
macOS 13.1

macOS set to english as primary language with german as secondary language. Region set to germany in case that plays a role, although it shouldn't.
Mixxx set to Language: System

Currently

Mixxx UI is german.

Expected

Mixxx UI should be english since it would be expected for Mixxx to follow system language.

The simple workaround obviously is to just set Mixxx language to english. Still found this to be unexpected behavior and thus reporting.

Version

2.4 alpha

OS

macOS 13.1

foss- added the bug label

Member

daschuer commented Jan 16, 2023

There is probably a bug in Qt that is fixed in Qt 6.2
https://github.com/qt/qtbase/commits/24e8a693cdf418a90559472addfd49637ff4e270/src/corelib/text/qlocale_mac.mm

Maybe this one:
qt/qtbase@d8158c6
https://bugreports.qt.io/browse/QTBUG-90971

Member

daschuer commented Jan 18, 2023

The Qt call and the native getMacLocalName() return the same:

Debug [Main]: QLocale::system() = QLocale(English, Latin, Germany)
Debug [Main]: getMacLocaleName() = "en_DE"

Member

daschuer commented Jan 18, 2023

I have tried to reproduce the issue on Ubuntu Focal by manual edit the mixxx.cfg to

Locale en_DE

But it uses English as expected.

Please check that as well.

Contributor Author

foss- commented Jan 19, 2023

Additional testing:

open ~/Library/Containers/org.mixxx.mixxx/Data/Library/Application Support/Mixxx/mixxx.cfg`
edit Locale and use Locale en_DE
save and start mixxx

Mixxx launches with en UI.

daschuer added a commit to daschuer/mixxx that referenced this issue


          Fix assuming wrong system langage on macOS, fixes mixxxdj#11195

9ae8d6d

daschuer added a commit to daschuer/mixxx that referenced this issue


          Fix assuming wrong system langage on macOS, fixes mixxxdj#11195

037dd0a

Member

daschuer commented Jan 21, 2023

What does echo $LANG return? For me it is de_DE.UTF-8

daschuer added a commit to daschuer/mixxx that referenced this issue


          Fix assuming wrong system langage on macOS, fixes mixxxdj#11195

a39ec42

daschuer added a commit to daschuer/mixxx that referenced this issue


          Fix assuming wrong system language on macOS, fixes mixxxdj#11195

521b515

Swiftb0y added a commit that referenced this issue


          Merge pull request #11218 from daschuer/gh11195

d1f6337

Fix assuming wrong system language on macOS, fixes #11195

Member

ronso0 commented Jan 26, 2023

Fixed by #11218

ronso0 closed this as completed

daschuer mentioned this issue

macOS: use preferred language instead of region for Mixxx > Interface > Locale when set to System #11899

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment