Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waveforms like RekordBox: more difference between ups and downs along the song #11833

Open
ejgutierrez74 opened this issue Aug 15, 2023 · 11 comments

Comments

@ejgutierrez74
Copy link

Feature Description

Same song in Mixxx or Rekordbox, the waveform is much clearer in Rekordbox, specially the difference between ups and downs...

One example: difference between ups and downs is not clear
Captura desde 2023-08-15 18-34-44

The same song in Rekordbox:
imagen

The difference between ups and downs are clearer.

Perhaps with some tweaks you can fix this.

@hsn10
Copy link

hsn10 commented Aug 16, 2023

I think both preview waves are pretty useless. It is just background for marks (which are important).

There should be plugin system for waveforms + builtin plugin manager - both small ones and scrolling zoomed one - because there will be always discussions what wave is better.

@daschuer
Copy link
Member

Since Mixxx is open source there is no need for a Plug-In system. You are welcome to contribute a new waveform type directly to the Mixxx source.

@ejgutierrez74
Copy link
Author

I thought that i n preferences there is a tab for Waveform settings, perhaps changing or tweaking these options, you can make something similar to rekordbox...with more difference between ups and downs...and easier to put hot cues

@Swiftb0y
Copy link
Member

Whats the advantage of the style that rekordbox uses? Its just distorted, resulting in less and even downright misleading information IMO. Even when just comparing your screenshots, you can only really discern the break and verse from the rest. The fact that the different parts of the drops have different volume is completely lost. There is very little visual difference between the drop and intro&outro, information that is crucial for mixing.

Also: A plugin-system for waveform does not only not make much sense when the entire application is completely open anyways, its also infeasible under the constraints of modern graphics API's. That is unless you're okay with abysmal performance or essentially needing to compile the application anyways, at which point it would be easier to implement directly, as already suggested.

@ejgutierrez74
Copy link
Author

First advantage is that Rekordbox is an standard music for djing, so this could help many people switching or changing from Rekordbox or Traktor to Mixxx.

Im a newbie trying to learn the basics ind djing and Waveform in Rekordbox, is easier to understand for me, with very little knowledge and experience. When i became something like bob Sinclair or David Guetta, perhaps id change my opinion, and would prefer Mixxx waveform ;)

@Swiftb0y
Copy link
Member

I don't think "lets copy other software's questionable/worse (subjective) design simply because it has been established as a standard" is a good argument. Any beginner that has ever seen a "real"/undistorted waveform will very likely prefer Mixxx's waveforms over Rekordbox's. That said, this is just my personal opinion and you'd be welcome to contribute Rekordbox waveforms if you want to see them.

@mxmilkiib
Copy link
Contributor

mxmilkiib commented Oct 27, 2023

Link to the prior Zulip conversation as I try to make the waveforms as exactly like Pioneers because they are industry standard and more immedietly informative than any of Mixxx's default options: https://mixxx.zulipchat.com/#narrow/stream/247619-UI-.26-UX-design/topic/3-Band.20Waveforms

I'm getting though a bug where the waveforms don't look the same the second time the same settings are selected, not sure if that maps to an existing issue already or not..

Edit: a "waveform preset" feature, not a "waveform plugin" feature, would be sensible imho, decoupling the waveform type styles from the skin, cos it seems OTT to have edit the skin to get Pioneer-like (three colour "Filtered (GLSL)") waveforms that will just be overwritten when I next install a new version of Mixxx.

@mxmilkiib
Copy link
Contributor

Waveform presets: #10123

@uklotzde
Copy link
Contributor

The filtering and color mapping used by Mixxx seems to differ greatly from what other applications like Rekordbox are using:

https://codeberg.org/moire/moire/pulls/129#issuecomment-1528014

The green parts of the tested track indicate beatless parts with instrumentals and vocals. These are not visible in Mixxx.

@uklotzde
Copy link
Contributor

Out of curiosity I partially ported the filtering and color/amplitude mapping from audio-viz to Mixxx and the improvements are more than obvious.

Before

Screenshot from 2024-01-23 02-55-52

After

Screenshot from 2024-01-23 02-50-25

I had to disable the skin color filtering of the overview waveforms for the full color spectrum. The effect is like removing shades.

@ejgutierrez74
Copy link
Author

Thanks for your work..would be great to compare the waveform with Rekordbox...
Any ETA when would be avalaible ??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants