Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LateNight: use default RGB waveform colors #12712

Merged
merged 1 commit into from Feb 3, 2024

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Feb 2, 2024

The recent waveform discussions and especially Uwe's demo of an alternative signal drawing implementation made me realize how 'muddy' PaleMoon's waveforms look like in comparison to the default colors.

I suggest to remove the custom colors.

current:
wave_current

defaults / this PR:
wave_default

I did not yet look at the other skins.

@ronso0 ronso0 added this to the 2.4.0 milestone Feb 2, 2024
@github-actions github-actions bot added the skins label Feb 2, 2024
@ronso0 ronso0 added the waveform label Feb 2, 2024
@ronso0 ronso0 changed the title LateNight: use default TGB waveform colors LateNight: use default RGB waveform colors Feb 2, 2024
@m0dB
Copy link
Contributor

m0dB commented Feb 3, 2024

Yeah, that looks nicer

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@daschuer daschuer merged commit e0322b2 into mixxxdj:2.4 Feb 3, 2024
14 checks passed
@ronso0 ronso0 deleted the latenight-waveform-colors branch February 3, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants