Crossfader visible all time

[RafaelFrance]

Feature Description

First thanks for all Mixxx developpers.

I play Swing musics for couple dancers (that means no controller, no effect, no filter, no samples, to play music from beginning to end with a silent between tracks). Tango Skin.

I use only AutoDJ without using the Mixer itself, so I can reduce a lot the items of the screen. Reduction of items is even more interesting for beginner people who are afraid to have so many information that they do not need. It always a difficult step to explain Mixxx to people who they discover Mixxx.

When I hide the the Mixer (button Toggle Mixer), I do not see anymore on which side the crossfader is. I need to see the crossfader side all time, also because when I stop AutoDJ I need to see that crossfader .

My suggest is to let crossfaser visible all time, even when Mixer is hidden.

[ronso0]

Yes, that could work.
It wouldn't make sense to bind this to [AutoDJ],enabled because then it would be hidden as soon as AutoDJ loaded the last rack from the queue.

[RafaelFrance]

Yes, I agree

[ronso0]

@RafaelFrance Are you interested in fixing this yourself?
The change is trivial, just remove the visible connection from the crossfader box in Tango/topbar.xml
No need to compile, just fork Mixxx and work on top of the 2.4 branch.

[RafaelFrance]

@ronso0 sorry, but I am too afraid to do that. This is too complex for me.

But looking the code I thing it could be good to keep crossfader visible both when

• hidden mixer
• maximize library

That means crossfader always visible.

[ronso0]

Afraid of what?
You don't even need to get your hands dirty with git, you can work directly on the files Github.dev:
https://docs.github.com/en/codespaces/the-githubdev-web-based-editor
Tango topbar.xml:
https://github.dev/mixxxdj/mixxx/blob/2.4/res/skins/Tango/topbar.xml

Anyway, I opened #12703 but I suggest you look into those resources in case you have other skin tweaks in mind you want to propose.

[RafaelFrance]

@ronso0

Thanks of doing the PR.
It seems to be pushed, but I have not see impact on the last 2.4 beta (2.4-beta-430-g9cfcf85b40).

About implementing the Mixxx code, I do not know to do that. I used C++ a little bit long time ago, but never with graphical interfaces and not in a Github framework.

I will continu on French translation (application and manual).
I would like to work in the future on a daylight Tango skin. I think it could be possible for me because it should be mainly style sheet and graphic drawing, without code impact.

[ronso0]

A PR has to be merged for the changes to be in official builds.

Also, this is no code actually, just changes in the skin xml (where 'ml' stands for markup language), so you don't have to touch c++ and therefore also not build Mixxxx.

Re daylight Tango skin:
yes, that can mostly be done with stylesheets/icons, though I think some variables are inevitable since the knob graphics are set in xml. See the LateNight example:

mixxx/res/skins/LateNight/skin.xml

Lines 124 to 143 in ae53865

	<Schemes>
	<Scheme>
	<Name>PaleMoon</Name>
	<!-- Mix any of the existing button, knob, slider or style theme subsets.
	The button templates for example link to skins:LateNight/BtnTheme/buttons/btn_...
	BtnScheme borders / background images for pushbuttons, spinboxes,
	effect selector, AutoDJ fade mode selector.
	If 'BtnSize' variable is undefined it links to transparent
	dummy icons like btn_embedded__active.svg
	Note: Icons for buttons that have images set in xml already are set
	in the respective style-[theme].qss
	KnobScheme guess what
	SliderScheme ...exactly!
	StyleScheme icons & backgrounds for library, splitters, spinnies,
	VU meter, default cover art etc. -->
	<Style src="skins:LateNight/style_palemoon.qss"/>
	<SetVariable name="BtnScheme">palemoon</SetVariable>
	<SetVariable name="KnobScheme">palemoon</SetVariable>
	<SetVariable name="SliderScheme">palemoon</SetVariable>

mixxx/res/skins/LateNight/mixer/eq_knob_left.xml

Lines 54 to 64 in ae53865

	<EffectParameterKnobComposed>
	<Pos>0,0</Pos>
	<Size>40f,34f</Size>
	<TooltipId>filter<Variable name="EqRange"/></TooltipId>
	<Knob>skins:LateNight/<Variable name="KnobScheme"/>/knobs/knob_indicator_regular_<Variable name="KnobColorEq"/>.svg</Knob>
	<BackPath>skins:LateNight/<Variable name="KnobScheme"/>/knobs/knob_bg_regular.svg</BackPath>
	<MinAngle><Variable name="PotiMinAngle"/></MinAngle>
	<MaxAngle><Variable name="PotiMaxAngle"/></MaxAngle>
	<ArcRadius><Variable name="ArcRadius"/></ArcRadius>
	<ArcThickness><Variable name="ArcThickness"/></ArcThickness>
	<ArcColor><Variable name="ArcColorEq"/></ArcColor>