-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash when recording and streaming OGG with a samplerate of 96000 #5701
Comments
Commented by: Pegasus-RPG Can we just not show 96000 as an option if Vorbis is selected? |
Commented by: Pegasus-RPG (BTW be sure to call it OGG Vorbis instead of just OGG, since an OGG file can technically contain a number of different codecs.) |
Commented by: bkgood Preferably not, having prefs in one pane (Sound Hardware) affected by prefs in My personal preference would be to downsample the 96k samples to 48k with On Monday, December 06, 2010 18:12:01 you wrote:
|
Commented by: Pegasus-RPG Oh, I thought he was talking about stream bit rate. If he does indeed mean sample rate, then I too vote for downsampling so at least your main output still runs at 96kHz, incase you're playing at a venue AND streaming. |
Commented by: raffitea I think downsampling is the best, too. Unfortunately, I've never worked with libsamplerate and my knowledge about audio processing is limited here. If someone other than me could implement the downsampling in EncoderVorbis::process(...) I would be thankful. |
Commented by: raffitea Oh and just to be precise here: LAME does already downsample for us. So we only have to touch the EncoderVorbis class. |
Commented by: rryan Pushing this to 1.10.1 since it's unlikely someone will hit this, and if they do they'll know immediately. |
Commented by: rryan As a stopgap, I added an error dialog when someone tries to set 96kbps + vorbis to 1.9.x. |
Commented by: rryan Also, I found out why this crashes. The immediate segfault is because we call ogg_stream_clear on a stream that has not been initialized. I added a boolean to indicate when we have initialized the ogg/vorbis data structures and that fixed the crash. It still can't stream, but at least it doesn't crash. |
Commented by: rryan Marking fixed since this bug is about the crash. I'll file a wishlist bug for 96kHz ogg vorbis support. |
Commented by: esbrandt Also see Wishlist bug for 96kHz ogg vorbis support @ lp:883381 |
Issue closed with status Fix Released. |
Reported by: raffitea
Date: 2010-12-06T22:14:57Z
Status: Fix Released
Importance: Critical
Launchpad Issue: lp686212
Tags: crash, recording, shoutcast, sidechain
While MP3 streaming and recording is possible with a samplerate of 96000 this is not true for OGG, The encoder does not support downsampling to 44100 or 48000 as opposed to LAME.
Two option:
1. We throw a message box and disable recording and shoutcast at 96000
2. Downsampling? I'm sure we've some code for that somewhere in Mixxx
The text was updated successfully, but these errors were encountered: