Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support microphone toggle button instead of push-to-talk #6021

Closed
mixxxbot opened this issue Aug 22, 2022 · 12 comments
Closed

Support microphone toggle button instead of push-to-talk #6021

mixxxbot opened this issue Aug 22, 2022 · 12 comments

Comments

@mixxxbot
Copy link
Collaborator

Reported by: rryan
Date: 2011-10-17T02:02:59Z
Status: Fix Released
Importance: Wishlist
Launchpad Issue: lp876139
Tags: microphone
Attachments: power_window.patch, power_window2.patch, power_window3.patch


For some use-cases, toggling the microphone is better than push-to-talk.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2011-10-17T06:19:51Z


Idea:

We may do it like the power window in my car:
Short push: enable microphone
Second short push: disable microphone
Long push t > 0,5 s: push-to-talk

@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2011-10-19T23:58:54Z


That sounds like a good way to do it to me.

2011/10/17 Daniel Schürmann <email address hidden>

Idea:

We may do it like the power window in my car:
Short push: enable microphone
Second short push: disable microphone
Long push t > 0,5 s: push-to-talk

--
You received this bug notification because you are a member of Mixxx
Development Team, which is subscribed to Mixxx.
https://bugs.launchpad.net/bugs/876139

Title:
Support microphone toggle button instead of push-to-talk

To manage notifications about this bug go to:
https://bugs.launchpad.net/mixxx/+bug/876139/+subscriptions

@mixxxbot
Copy link
Collaborator Author

Commented by: Pegasus-RPG
Date: 2011-11-05T20:09:13Z


Until this is implemented, I found a workaround: put your mouse pointer over the talk button then hold the left mouse button, then hold the right one down too, then release the left, then release the right. That will cause the talk button to "stick" on for as long as you like. (Simply left-clicking it will release it.)

I also like the power window idea. We could also/instead use the right mouse button to toggle it while the left does PTT.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2011-11-24T22:09:20Z


Hi Sean,
your workaround does not work on ubuntu oneiric.

I am currently trying to make a power window button with an additional latching function with the right mouse button.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2011-12-10T22:51:14Z
Attachments: power_window.patch


The attached patch introduces a power window mode for push buttons.
It works for mouse, keyboard and midi. The skins are updated for the microphone button.

It was tested together with the patch from bug #⁠900255 and bug #⁠686377 on lp:mixxx #⁠2972

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2011-12-17T18:33:09Z
Attachments: power_window2.patch


Updated patch for current lp:mixxx #⁠2973

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2011-12-21T20:21:55Z


The attached patch is obsolete, please use the patch from Bug #⁠906310

@mixxxbot
Copy link
Collaborator Author

Commented by: esbrandt
Date: 2012-03-13T08:31:39Z


Using the "Power window" patch since a while and it works really well.
Since the related lp:906310 is nominated for 1.11 , il add this one to 1.11 as well.

TODO: Update skins tooltips to reflect the new functionality if patch get merged.

@mixxxbot
Copy link
Collaborator Author

Commented by: michael-odonnell
Date: 2012-03-29T03:31:05Z


I will also appreciate a toggle feature. I use the microphone in ways that are incompatible with holding a button down. I usually prefer the keyboard button ("`") to the mouse click.

I had some success with a workaround: press the "`" or mouse button, keep it down while capturing the keyboard focus in another window, then release. I had record on for some minutes this way, but at some point I was unable to turn it off (the display showed it going on and off, but the microphone input still played through and showed on the level meters). I haven't had a chance to chase down the alternatives.

My best workaround is mechanical: a small flashlight pressing the "`" key.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2012-04-19T19:34:56Z
Attachments: power_window3.patch


Updated patch against lp:mixxx #⁠3025.
Changed short klick time from 300 to 200 ms optimised to the use for EQ-Kill Switch bug #⁠918470

@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2012-05-01T06:03:44Z


After some careful testing I think this looks good. Since the patch also included some other stuff from another one of your patches I committed only the powerwindow-specific things to lp:mixxx. I also see now how the toggling for single-state WPushButton's that was done previously could have easily led to button-getting-out-of-sync issues that we have seen over the years so thanks for fixing that too.

I changed your patch a little bit so that a <PowerWindow> block doesn't have to be added to buttons in the skin. Instead, it looks at the controls connected to the left and right click on WPushButton and records their button-mode in WPushButton. When clicks happen on WPushButton, it checks the left button-mode to see if powerwindow mode is enabled. I think this is cleaner since it makes sure that a skin designer can't accidentally forget to enable power-window mode for things like talkover.

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 1.11.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant