Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-Dj hangs if a song is shorter then the fading time #6627

Closed
mixxxbot opened this issue Aug 22, 2022 · 3 comments
Closed

Auto-Dj hangs if a song is shorter then the fading time #6627

mixxxbot opened this issue Aug 22, 2022 · 3 comments
Milestone

Comments

@mixxxbot
Copy link
Collaborator

Reported by: kain88-de
Date: 2012-09-07T21:54:37Z
Status: Fix Released
Importance: Low
Launchpad Issue: lp1047655
Tags: autodj
Attachments: autoDj_fade.patch


If you set fading time to 20sec and have a song in the auto-dj queue that is only 5sec AutoDj will stop playing on any deck after the short track finishes. This will always occur when the song is shorter then the fading time

@mixxxbot
Copy link
Collaborator Author

Commented by: kain88-de
Date: 2012-09-25T22:04:14Z
Attachments: autoDj_fade.patch


This will change the fade duration to half the tracklength if it is shorter then the duration time.
Additionally I save the old duration time and change it back if a new song is loaded.

I tested with several queues and tried to cover all cases I could think of. For me Auto DJ now works regardless of set fading time and tracklength

@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2012-09-26T00:35:13Z


Nice one Max -- committed.

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 1.11.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant