Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide meaningful error messages when Mixxx fails to lookup MusicBrainz metadata #7053

Closed
mixxxbot opened this issue Aug 22, 2022 · 5 comments
Closed

Provide meaningful error messages when Mixxx fails to lookup MusicBrainz metadata #7053

mixxxbot opened this issue Aug 22, 2022 · 5 comments
Labels
bug metadata usability
Milestone
2.0.0

Comments

@mixxxbot
Copy link
Collaborator

Reported by: esbrandt
Date: 2013-05-25T15:51:37Z
Status: Fix Released
Importance: Medium
Launchpad Issue: lp1184158
Tags: metadata, usability
Attachments: musicbrainzNetworkError.patch

Tested with lp:trunk

Currently Mixxx always trows a "Sorry. Mixxx could not find this song" message.

There is no distinction between:
A) no matching metadata for the selected track available @musicbrainz
b) no connection to the MusicBrainz servers (User offline, connection blocked, host down, etc.)
@mixxxbot
Copy link
Collaborator Author

Commented by: kain88-de
Date: 2013-05-26T17:01:34Z
Attachments: musicbrainzNetworkError.patch

This patch will load a network error page if one of the HTTP requests fails. Otherwise the old error message is shown

@mixxxbot
Copy link
Collaborator Author

Commented by: esbrandt
Date: 2013-06-16T11:21:36Z

Thanks Max, tried your patch.
Some comments:

The new network error page says:
"Sorry
Mixx can't connect to the internet
HTTP status: 0"

  • "Error" should replace the word "Sorry"
    We should emphasize that there an error, no need to apologize

  • Because thee patch does not differentiate between host down ("The server is not responding or is not reachable") and no internet connection ("The Internet connection appears to be offline"), we should at least specify the problem and provide some tips as to how the problem may be solved.

  • Drop the "HTTP status" bit if it can't provide extra information to the person who is troubleshooting. Is there even a status 0? Not listed in https://en.wikipedia.org/wiki/List_of_HTTP_status_codes

  • The translatable strings in the *.ui files contain unwanted HTML blobs. We generally try to get rid of them ( lp:954234 ), at least we should not introduce new ones. A translator is currently presented a text in the form of

    <html><head/><body><p align="center">Mixxx can't connect to the internet</p></body></html>

This often leads to translation errors, or even untranslated strings. Using unambiguous strings is the foundation for having strings translated.

It may seem a bit too much noise for such a simple simple error message, but let's not forget that devs knows a product in much more detail then the average user, who is the addressee of the message.

@mixxxbot
Copy link
Collaborator Author

Commented by: kain88-de
Date: 2013-06-16T12:27:01Z

I only tried the error messages when I disconnected my internet. Then Qt gives me 0 as a HTTP Error. I guess that is their code for 'no connection'. I'll see if I can test this more and update the patch then, I would in general like to keep the HTTP status when I can use it to distinguish between host down and no internet connection.

I'll also check the ui file again to remove the HTML blobs

@mixxxbot
Copy link
Collaborator Author

Commented by: kain88-de
Date: 2013-06-23T17:25:48Z

#19

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.0.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug metadata usability
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@mixxxbot