Show better error messages when talking to MusicBrainz. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
June 19, 2013 00:35
| @@ -75,7 +75,9 @@ void AcoustidClient::requestFinished() { | |||
| int id = m_requests.take(reply); | |||
|
|
|||
| if (reply->attribute(QNetworkRequest::HttpStatusCodeAttribute).toInt() != 200) { | |||
| emit finished(id, QString()); | |||
| emit networkError( | |||
There was a problem hiding this comment.
Whoops, can you put parens after emit?
emit(foo);
There was a problem hiding this comment.
Well I can do
emit foo(bar);
There was a problem hiding this comment.
emit(foo(bar)); is how we do it everywhere in Mixxx. Today Qt defines emit as an empty statement which is why that works but in the future they could change that.
|
Looks good other than those minor comments. Thanks! |
|
It looks ok using the style options for the QLabel
|
|
Cool -- thanks for the fixes! |
rryan
added a commit
that referenced
this pull request
Jun 25, 2013
Show better error messages when talking to MusicBrainz.
Merged
11 tasks
Holzhaus
pushed a commit
that referenced
this pull request
Sep 23, 2021
CI: Update Docker image for GitHub pre-commit workflow
m0dB
pushed a commit
to m0dB/mixxx
that referenced
this pull request
Jan 21, 2024
2.1 beta downloads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.launchpad.net/mixxx/+bug/1184158
Show a more meaningfull error message when mixxx fails to reload metadata from the internet.
If we get a HTTPErrorCode from the service it will show the error and service.
If we don't get a HTTPErrorCode a more generic site is shown naming the service that failed.
To test this behaviour just mess up the URL variables in acoustidclient.cpp and musicbrainzclient.cpp
I haven't touched the .ui files much. I would like to have some words centered and in bold but I can't figure out how this is done without using HTML in the QLabel. Jus do you know a way to do this in QtDesigner?