Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No track end warning if waveform renderer is set to empty #7114

Closed
mixxxbot opened this issue Aug 22, 2022 · 5 comments
Closed

No track end warning if waveform renderer is set to empty #7114

mixxxbot opened this issue Aug 22, 2022 · 5 comments
Milestone

Comments

@mixxxbot
Copy link
Collaborator

Reported by: ferranpujolcamins
Date: 2013-07-23T23:45:38Z
Status: Fix Released
Importance: Low
Launchpad Issue: lp1204294
Tags: waveform


If waveform renderer is set to empty, then the track end warning does not work in the waveform overview.

Not sure if it's a bug or an intended behaviour.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2013-07-24T06:45:25Z


Yes, This is a bug!

I would be happy if you can adopt it according to my hints from mixxx-devel.
Thank you!

@mixxxbot
Copy link
Collaborator Author

Commented by: esbrandt
Date: 2017-07-09T16:43:14Z


I think the end of track warning does not belong to the main waveform at all, it is pretty redundant there.

Currently we display
a) A blinking gradient on the background of the main waveform
b) a static rectangle on the background of the waveform overview.

The end of track warning should go as blinking rectangle exclusively to the waveform overview. Saves performance on the main waveform, while being always prominently visible on the waveform overview.

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2018-12-23T18:27:48Z


I agree, there should be a blinking rectangle in the overview. Now, that we have 3 skins where the scrolling waveforms can be hidden it's easy to miss the warning. It would also help a lot in minimal decks with max. library' #1933 which is almost finished.

To get the most attention for the end warning it should be stacked on top of the dimmed (played) part of the overview
https://bugs.launchpad.net/mixxx/+bug/1792797

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2018-12-25T14:58:15Z


#1963

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.3.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant