Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Mixxx mime type aware #7970

Closed
mixxxbot opened this issue Aug 22, 2022 · 5 comments
Closed

make Mixxx mime type aware #7970

mixxxbot opened this issue Aug 22, 2022 · 5 comments
Labels
Milestone

Comments

@mixxxbot
Copy link
Collaborator

Reported by: daschuer
Date: 2015-04-19T09:27:35Z
Status: Fix Committed
Importance: High
Launchpad Issue: lp1445885


To improve the detection of various media files. It will be nice to rely on the mime-type detection, rather use the file extension.
We may use libmagic or the Qt 5 mime type support.

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2021-10-05T09:12:19Z


This is actually a serious bug that may cause various issues:

https://mixxx.discourse.group/t/mixxx-has-stopped-plaing-newly-downloaded-mp3s/23074/21

I have also seen weird decoded audio signals produced by SoundSourceMP3 which might damage output devices. The combination of the dreaded MP3 format in combination with the ancient libmad library for decoding is dangerous.

@mixxxbot mixxxbot added the bug label Aug 22, 2022
@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2021-10-05T10:21:59Z


#4356
#4357

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2022-01-07T10:36:13Z


This bug is not fixed completely in 2.3.2. Mixxx still detects the wrong MIME type and tries to open the file with the registered SoundSources.

On Linux some tracks with the wrong file extension can be played if FFmpeg is enabled, because it is capable of playing almost every format and kicks in as a fallback SoundSource. On Windows and macOS .mp3 files that actually contain an AAC stream in DASH container as reported by the user will probably fail to play such a file file.

Even 2.4.x does not fix the wrong file type in Mixxx of previously imported files. I will take a look.

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2022-01-07T16:53:50Z


Follow-up: #4608

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Committed.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.4.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant