Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lp1445885: Detect MIME type and deduce expected file extension and type #4356

Merged
merged 1 commit into from
Oct 5, 2021
Merged

lp1445885: Detect MIME type and deduce expected file extension and type #4356

merged 1 commit into from
Oct 5, 2021

Conversation

uklotzde
Copy link
Contributor

@uklotzde uklotzde commented Oct 5, 2021

Checking only the actual file extension is not sufficient.

Fixes: https://bugs.launchpad.net/mixxx/+bug/1445885

@Holzhaus
Copy link
Member

Holzhaus commented Oct 5, 2021

Thank you!

@Holzhaus Holzhaus merged commit b237b50 into mixxxdj:2.3 Oct 5, 2021
@Holzhaus Holzhaus added the changelog This PR should be included in the changelog label Oct 5, 2021
@Holzhaus
Copy link
Member

Holzhaus commented Oct 5, 2021

This deserves a changelog entry IMHO. @uklotzde could you add one?

@Holzhaus Holzhaus added this to the 2.3.2 milestone Oct 5, 2021
@uklotzde
Copy link
Contributor Author

uklotzde commented Oct 5, 2021

I forgot to consider uppercase suffixes. Fix and changelog entry will follow.

@Holzhaus
Copy link
Member

Holzhaus commented Oct 5, 2021

I forgot to consider uppercase suffixes.

Wouldn't that just be another instance of "unknown suffix"?

@uklotzde
Copy link
Contributor Author

uklotzde commented Oct 5, 2021

Sure, but the warnings in the log are misleading and confusing.

And the test fails for missing files or unknown MIME types where only the suffix is available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog This PR should be included in the changelog code quality major bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants