Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose skin scaling options to the preferences #9640

Closed
mixxxbot opened this issue Aug 23, 2022 · 9 comments
Closed

Expose skin scaling options to the preferences #9640

mixxxbot opened this issue Aug 23, 2022 · 9 comments

Comments

@mixxxbot
Copy link
Collaborator

Reported by: nschloe
Date: 2019-04-22T10:17:56Z
Status: Confirmed
Importance: Medium
Launchpad Issue: lp1825816
Attachments: mixx.png


I've got a 12 inch laptop with a 1080p (1920x1080) display (which I think are fairly common nowadays). In the mixxx interface, unfortunately, everything is really small. The fonts are small, and the clickable buttons are between 10 and 20 pixels wide. For comparison, the back, forth and reload buttons on this chrome browser are about 30 pixels wide.

I know that I can adjust the library font size. What other knobs are there? Can I adjust, for example, the font size in the other parts of the interface?

@mixxxbot
Copy link
Collaborator Author

Commented by: nschloe
Date: 2019-04-22T10:17:56Z
Attachments: mixx.png

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2019-04-22T10:36:03Z


This is an other aspect of https://bugs.launchpad.net/mixxx/+bug/1793954

I think it is really required to expose the scaling options again.

A intermediate solution was proposed here:
#1741

@mixxxbot
Copy link
Collaborator Author

Commented by: nschloe
Date: 2019-04-22T13:06:57Z


export QT_AUTO_SCREEN_SCALE_FACTOR=0
export QT_SCREEN_SCALE_FACTORS=1.4

works for me.

@mixxxbot
Copy link
Collaborator Author

Commented by: Be-ing
Date: 2019-04-22T15:00:10Z


Once again, this is Qt's responsibility, not the responsibility of every application. We only need to inform users how to manually adjust scaling when Qt's automatic scaling fails, which it inevitably will in some cases with the wide variety of resolutions and physical screen sizes available.

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2019-04-22T15:26:14Z


It is not only Qt's responsibility since we decided to explicitly opt-in into auto-scaling with unforeseeable side effects. Now one has to set QT_AUTO_SCREEN_SCALE_FACTOR=0 to restore the default behavior in order to follow the instructions documented by Qt.

That's the problem with those half-baked solutions. Either you provide the full scale of configuration options or entirely leave it to someone else.

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2019-04-22T15:29:29Z


why "won't fix"?

this is Qt's responsibility ... inform users how to manually adjust scaling

I disagree. Even though Qt's scaling might work if every screen also supplies info about its physical size, there are use cases where manual adjust of the scaling is required and we may not expect users to mess with the command line or .bat/.desktop files. Because, if they are simply not skilled or brave enough to go to this level of their OS they will just drop Mixxx and re-try the DJ app which probably came with their controller.

+1 for scaling controls in Preferences

@mixxxbot
Copy link
Collaborator Author

Commented by: Be-ing
Date: 2019-04-22T15:42:08Z


If we can change Qt's scale factor from the preferences, okay, but not elaborate hacks duplicating what Qt already does for us (like #1741). However I am doubtful we can adjust Qt's scale factor within a Qt application. IIRC it needs to be set before any GUI is shown.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2019-04-22T16:45:21Z


It is OK to restart Mixxx after tweaking the preferences option.
It is better than fiddling with a batch file.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@ronso0
Copy link
Member

ronso0 commented May 23, 2024

Fixed by #3960

@ronso0 ronso0 closed this as completed May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants