Star ratings not reacting to click

[mixxxbot]

Reported by: foss-4
Date: 2020-04-05T12:15:49Z
Status: Fix Released
Importance: Low
Launchpad Issue: lp1870909
Tags: gui
Attachments: [mixxx not recognizing clicks on star rating.mp4](https://bugs.launchpad.net/bugs/1870909/+attachment/5346959/+files/mixxx not recognizing clicks on star rating.mp4), [star ratings in deck off by one star](https://bugs.launchpad.net/bugs/1870909/+attachment/5394963/+files/star ratings in deck off by one star)

---

macOS 10.15.4
Mixxx 2.3.0-alpha-pre (build master r7219)
Skin: any

Setting a star rating is currently confusing and not at all behaving as expected:

On mouseover the stars are showing up, but mixxx is unresponsive on any click on one of the stars and it seems the rating is not recognized. See attached video.

[mixxxbot]

Commented by: foss-4
Date: 2020-04-05T12:15:49Z
Attachments: [mixxx not recognizing clicks on star rating.mp4](https://bugs.launchpad.net/mixxx/+bug/1870909/+attachment/5346959/+files/mixxx not recognizing clicks on star rating.mp4)

[mixxxbot]

Commented by: al3xf
Date: 2020-06-08T06:41:17Z

---

I also find the rating behavior very confusing, actually on my workstation (macOS Catalina, Mixxx v2.2.3) if I mouse over the stars they show up regardless of the actual metadata and sometimes they stick to 5 stars after the mouse over.

I'd love to be able to use it as other metadata fields, i.e. set it directly from Mixxx, and not having any visual behavior change when mouse pointer goes over the stars.

[mixxxbot]

Commented by: foss-4
Date: 2020-07-22T17:41:19Z

---

More odd behavior in regards to mouse behavior and star ratings on macOS:

when trying to set a star rating in the deck, it is misaligned and seems to react one star off. see screencast.

[mixxxbot]

Commented by: foss-4
Date: 2020-07-22T17:42:06Z
Attachments: [star ratings in deck off by one star](https://bugs.launchpad.net/mixxx/+bug/1870909/+attachment/5394963/+files/star ratings in deck off by one star)

[mixxxbot]

Commented by: ronso0
Date: 2020-07-23T13:50:36Z

---

the rating is applied on mouse release.
do you use a mouse or the mac trackpads?

[mixxxbot]

Commented by: ronso0
Date: 2020-07-23T13:53:34Z

---

I'd love to be able to use it as other metadata fields, i.e. set it directly from Mixxx

@Al3xF What do you mean?
There are controls to change the star rating via controller. In https://github.com/mixxxdj/mixxx/wiki/mixxxcontrols look for 'stars_up'. I guess you can use those controls for a keyboard mapping as well.

[mixxxbot]

Commented by: ronso0
Date: 2020-07-23T13:57:15Z

---

@Al3xF Are you able to build mixxx on MacOS?
If so you can try to catch the mousePressEvent instead of mouseReleaseEvent.
Repsective code is there: https://github.com/mixxxdj/mixxx/blob/master/src/widget/wstarrating.cpp#L143

[mixxxbot]

Commented by: foss-4
Date: 2020-07-23T15:01:52Z

---

"the rating is applied on mouse release."
using trackpad here: https://bugs.launchpad.net/mixxx/+bug/1870909/+attachment/5394963/+files/star%20ratings.mp4

Is it intended to adapt any change without an actual click? I would expect only to change something when clicking on it (not hoovering - and accidentally lifting the finger).

[mixxxbot]

Commented by: ronso0
Date: 2020-07-23T15:53:24Z

---

I'm not sure what the reason was to use the release event.
on Linux and Windows this works with a explicit clicks only.

alternatively we may use both mousePressEvent AND mouseRelaseEvent and in the latter check if both occured in roughly the same spot (custom single click detection).

Or we simply use mouseDoubleClickEvent on macOS only because the current implementation works on Linux and Windows.

btw: does the library star rating work or is it suffering the same issue?

[mixxxbot]

Commented by: foss-4
Date: 2020-07-27T15:42:45Z

---

library ratings are not affected by the "off by one star" problem.

[mixxxbot]

Commented by: foss-4
Date: 2020-08-05T11:32:23Z

---

Behavior in 2.4.0-alpha-pre (build master r7487) has improved the star rating behavior in library view a lot.

I think it's fair to close this issue. Setting to fix commited even without specific commit as there is no worksforme state.

Tested w macOS 10.15.6.

Followup issue for the misaligned star rating in deck view is here:
https://bugs.launchpad.net/mixxx/+bug/1890430

@alex would be great if you could test this as well, confirm the followup bug and maybe also confirm that the problem with star ratings in library view is also solved for you.

[mixxxbot]

Commented by: foss-4
Date: 2020-08-30T20:01:35Z

---

Tested and 2.3.0-beta (build 2.3 r7546) on macOS 10.15.6 + Supplement Update works as expected.

[mixxxbot]

Issue closed with status Fix Released.