Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

History: disallow dropping tracks #10969

Merged
merged 1 commit into from
Oct 21, 2022
Merged

History: disallow dropping tracks #10969

merged 1 commit into from
Oct 21, 2022

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Oct 15, 2022

closes #10250

@ronso0 ronso0 mentioned this pull request Oct 15, 2022
Closed
@ronso0 ronso0 added this to the 2.3.4 milestone Oct 15, 2022
@ronso0 ronso0 linked an issue Oct 15, 2022 that may be closed by this pull request
accidentally dropped files into a History playlist and can't remove them from there #10250
Closed
@ronso0
Copy link
Member Author

ronso0 commented Oct 16, 2022

On that topic:
I think the "Remove" action is really useful to clean up set lists, for example to remove tracks from the soundcheck after forgetting about 'Start new' (split history), or played tracks that didn't make it into the main mix (recording) in a back-to-back session.
And it would comply with disallowing rewriting the history. 'Forgetting' events is different from creating new ones : )

@ronso0
Copy link
Member Author

ronso0 commented Oct 16, 2022 •
edited
Loading

#10974

daschuer
daschuer approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and works. Thank you.

@daschuer daschuer merged commit a25c021 into mixxxdj:2.3 Oct 21, 2022
@ronso0 ronso0 deleted the history-reject-drops branch October 21, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
library
Projects
None yet
Milestone
2.3.4
Development

Successfully merging this pull request may close these issues.

accidentally dropped files into a History playlist and can't remove them from there
2 participants
@ronso0 @daschuer