Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qopenglwindow-based replacement of qglwidget, full glsl shader based waveforms, vumeters and spinnies #10989

Merged
merged 122 commits into from May 29, 2023
Merged

qopenglwindow-based replacement of qglwidget, full glsl shader based waveforms, vumeters and spinnies #10989

merged 122 commits into from May 29, 2023

Commits on May 26, 2023

  1. replaced use of qglwidget with wglwidget, add qopengl renderers, qope… 

    …ngl rgbwaveformwidget and qopengl wvumetergl and qopengl wspinny
    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    8aef319 View commit details
    Browse the repository at this point in the history

  2. wspinny qopengl implementation as extension of standard wspinny with … 

    …some ifdefs, instead of having a copy

removed unneeded includes
    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    3b1b5d1 View commit details
    Browse the repository at this point in the history

  3. wvumetergl qopengl implementation as extension of standard wvumetergl… 

    … with some ifdefs, instead of having a copy
    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    facaab9 View commit details
    Browse the repository at this point in the history

  4. using float instead of fixedpoint for rgb waveform

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    30d65eb View commit details
    Browse the repository at this point in the history

  5. use VERIFY_OR_DEBUG_ASSERT

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    b037a13 View commit details
    Browse the repository at this point in the history

  6. default QOPENGL ON for all platforms

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    b53d0a5 View commit details
    Browse the repository at this point in the history

  7. Update src/waveform/renderers/qopengl/waveformrendererendoftrack.cpp 

    Co-authored-by: Daniel Schürmann <daschuer@mixxx.org>

added comment

Update src/waveform/renderers/qopengl/iwaveformrenderer.h

Co-authored-by: Daniel Schürmann <daschuer@mixxx.org>
    @m0dB @daschuer
    m0dB and daschuer committed May 26, 2023
    Configuration menu
    Copy the full SHA
    3d4ed50 View commit details
    Browse the repository at this point in the history

  8. dont always return true from shouldRender, comments, minor changes (a… 

    …cting on review comments from @daschuer)

fix formatting
    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    a536cc4 View commit details
    Browse the repository at this point in the history

  9. check if shaders are available for vumeter and spinny, else fall back… 

    … to non-shader implementation
    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    41e1f72 View commit details
    Browse the repository at this point in the history

  10. qopengl equivalent of querying opengl version and capabilities 

    hide instead of delete
    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    ca37ebe View commit details
    Browse the repository at this point in the history

  11. simplified class hierarchy by removing IWaveformWidget and add virtua… 

    …l renderGL to qopengl WGLWidget
    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    d79ee4a View commit details
    Browse the repository at this point in the history

  12. remove wrong/unneeded calls to makeCurrent / doneCurrent

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    80279cf View commit details
    Browse the repository at this point in the history

  13. explicitely render from paintGL to fix artifacts when resizing the wi… 

    …dget
    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    9e7213b View commit details
    Browse the repository at this point in the history

  14. propagate resizeGL to widget and renderers, resize markers in resizeG… 

    …L (fixes playhead marker not being resized)
    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    58120bc View commit details
    Browse the repository at this point in the history

  15. tweaks for more correct drawing of markers

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    a480188 View commit details
    Browse the repository at this point in the history

  16. avoid rare marker position rounding issue

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    9b2cb77 View commit details
    Browse the repository at this point in the history

  17. fix tooltips for qopengl based wglwidgets

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    92bb195 View commit details
    Browse the repository at this point in the history

  18. avoid float conversion errors on ubuntu 22.04 gcc

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    8fed99c View commit details
    Browse the repository at this point in the history

  19. more strict use of float/double to be able to compile these files wit… 

    …h -Wconversion with clang on macOS, hopefully solving compilation on ubuntu 22.04
    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    eae49c7 View commit details
    Browse the repository at this point in the history

  20. removed const from static_cast

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    7541dd5 View commit details
    Browse the repository at this point in the history

  21. postpone initialization until the initial qopenglwindow has been exposed

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    2dbaf56 View commit details
    Browse the repository at this point in the history

  22. draw correct slip position ghost in qopengl spinny

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    fb6e90c View commit details
    Browse the repository at this point in the history

  23. support vertical orientation by rotating the matrix (and thus removed… 

    … dual implementation for hor/ver)
    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    ddeb54c View commit details
    Browse the repository at this point in the history

  24. missing include memory

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    18333b7 View commit details
    Browse the repository at this point in the history

  25. explanation of qopengl classes and files

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    5029f5e View commit details
    Browse the repository at this point in the history

  26. explanation of qopengl classes and files - formatting

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    ffbd20b View commit details
    Browse the repository at this point in the history

  27. clear color buffer bit on paintDevice() request

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    dfbe712 View commit details
    Browse the repository at this point in the history

  28. fix crash of glvsynctestwidget

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    bffc84c View commit details
    Browse the repository at this point in the history

  29. fixed tooltips for wglwidgetqopengl

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    b5bc098 View commit details
    Browse the repository at this point in the history

  30. Update CMakeLists.txt 

    Co-authored-by: Swiftb0y <12380386+Swiftb0y@users.noreply.github.com>
    @m0dB @Swiftb0y
    m0dB and Swiftb0y committed May 26, 2023
    Configuration menu
    Copy the full SHA
    2a4a27d View commit details
    Browse the repository at this point in the history

  31. assert samplerate is positive 

    Co-authored-by: Swiftb0y <12380386+Swiftb0y@users.noreply.github.com>
    @m0dB @Swiftb0y
    m0dB and Swiftb0y committed May 26, 2023
    Configuration menu
    Copy the full SHA
    786ed1e View commit details
    Browse the repository at this point in the history

  32. simplified qopengl::WaveformRenderBackground: removed unused pixmap b… 

    …ackground code
    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    f28943d View commit details
    Browse the repository at this point in the history

  33. improved m_beatLineVertices memory management as suggested by @Swiftb0y

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    4de1da5 View commit details
    Browse the repository at this point in the history

  34. reserve (and assert) the read amount of vertices in waveformrenderbeat

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    a085b87 View commit details
    Browse the repository at this point in the history

  35. using reserve and push_back in qopengl::WaveformRendererrRGB

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    bfd4286 View commit details
    Browse the repository at this point in the history

  36. use "using" instead of "#define" for qgl vs qopengl classes

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    7a0a95e View commit details
    Browse the repository at this point in the history

  37. qopengl filteredwaveformwidget

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    bee4fe4 View commit details
    Browse the repository at this point in the history

  38. correct reserve

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    9b70593 View commit details
    Browse the repository at this point in the history

  39. c++ syntax instead of signal slot macros

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    6b1dcd2 View commit details
    Browse the repository at this point in the history

  40. add RGB renderer with separate RGB color for L/R channel

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    beb30a0 View commit details
    Browse the repository at this point in the history

  41. revert accidental use of direct connection for spinnies and vumeters … 

    …render and swap
    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    9ba52cd View commit details
    Browse the repository at this point in the history

  42. Update README-QOpenGL.md 

    Co-authored-by: Daniel Schürmann <daschuer@mixxx.org>
    @m0dB @daschuer
    m0dB and daschuer committed May 26, 2023
    Configuration menu
    Copy the full SHA
    d3bc7dd View commit details
    Browse the repository at this point in the history

  43. Update src/widget/tooltipqopengl.cpp 

    Co-authored-by: Daniel Schürmann <daschuer@mixxx.org>
    @m0dB @daschuer
    m0dB and daschuer committed May 26, 2023
    Configuration menu
    Copy the full SHA
    1e51f63 View commit details
    Browse the repository at this point in the history

  44. remove unneeded QT_FORWARD_DECLARE_CLASS

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    80cdf32 View commit details
    Browse the repository at this point in the history

  45. add comment clarifying need for handleEventFromWindow and moved toolt… 

    …ip handling to OpenGLWindow
    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    2271ac6 View commit details
    Browse the repository at this point in the history

  46. explicit call to clear paint device

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    52a9bdc View commit details
    Browse the repository at this point in the history

  47. added comments explaining qopengl::WaveformRenderer

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    e212e0d View commit details
    Browse the repository at this point in the history

  48. removed obsolete commented code

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    7a041c0 View commit details
    Browse the repository at this point in the history

  49. Update src/waveform/renderers/qopengl/waveformrendererendoftrack.cpp 

    Co-authored-by: Swiftb0y <12380386+Swiftb0y@users.noreply.github.com>
    @m0dB @Swiftb0y
    m0dB and Swiftb0y committed May 26, 2023
    Configuration menu
    Copy the full SHA
    3218eb6 View commit details
    Browse the repository at this point in the history

  50. using constexpr in anon namespace, using named const vars instead of … 

    …magic numbers
    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    578e5f9 View commit details
    Browse the repository at this point in the history

  51. removed unneeded inline

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    88c9d1b View commit details
    Browse the repository at this point in the history

  52. minor api change

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    0f1901e View commit details
    Browse the repository at this point in the history

  53. improved comment

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    2ad4199 View commit details
    Browse the repository at this point in the history

  54. typp

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    1b49354 View commit details
    Browse the repository at this point in the history

  55. remove code duplication by using a for loop for left/right channel

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    83b8719 View commit details
    Browse the repository at this point in the history

  56. limit preroll triangles to does that will be on screen + additional c… 

    …leanup
    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    9bd12df View commit details
    Browse the repository at this point in the history

  57. avoid corner case mismatch between reserved and drawn beat markers

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    2b14751 View commit details
    Browse the repository at this point in the history

  58. using vectors of QVector2D and QVector3D instead of float + cleanup

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    99e87bd View commit details
    Browse the repository at this point in the history

  59. moved shaders to files to reduce code duplication

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    a87a7be View commit details
    Browse the repository at this point in the history

  60. reduced code duplication by encapsulating vertex and color data in cl… 

    …asses
    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    2594742 View commit details
    Browse the repository at this point in the history

  61. reduced code duplication by moving ortho matrix calculation to helper… 

    … file
    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    326d4d3 View commit details
    Browse the repository at this point in the history

  62. Update src/waveform/renderers/qopengl/waveformrendererfiltered.cpp 

    Co-authored-by: Swiftb0y <12380386+Swiftb0y@users.noreply.github.com>
    @m0dB @Swiftb0y
    m0dB and Swiftb0y committed May 26, 2023
    Configuration menu
    Copy the full SHA
    e31da64 View commit details
    Browse the repository at this point in the history

  63. beter var name from visualIncrementPerPixel

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    9c725a3 View commit details
    Browse the repository at this point in the history

  64. added DEBUG_ASSERT(false)

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    864906e View commit details
    Browse the repository at this point in the history

  65. use encapsulation instead of inheritence of colordata and vertexdata,… 

    … added final where appropriate and additional clean-ups.
    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    4f6a056 View commit details
    Browse the repository at this point in the history

  66. added simple qopengl waveform renderer

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    fafa14f View commit details
    Browse the repository at this point in the history

  67. renamed calculatematrix to matrixforwidgetgeometry, removed unused wi… 

    …dgetrendertimer and minor improvement in textureshader
    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    1986780 View commit details
    Browse the repository at this point in the history

  68. protect call to numBeatsInRange from invalid positions

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    fd82ed3 View commit details
    Browse the repository at this point in the history

  69. using QTimer instead of unique_ptr<QTimer>, several cleanups, particu… 

    …larly spinny and vumeter, and did some renaming. fixed compilation for QOPENGL=OFF
    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    e2f6ffa View commit details
    Browse the repository at this point in the history

  70. removed unused include

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    ec9e6a2 View commit details
    Browse the repository at this point in the history

  71. rename function that draws to mark to drawMark

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    76032dd View commit details
    Browse the repository at this point in the history

  72. changed user-facing names of waveforms types

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    97285fe View commit details
    Browse the repository at this point in the history

  73. avoid double to float conversion warning

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    3729370 View commit details
    Browse the repository at this point in the history

  74. fix clazy error

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    4b28aaf View commit details
    Browse the repository at this point in the history

  75. removed unnecesary dtor

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    75d2554 View commit details
    Browse the repository at this point in the history

  76. put back some ifdefs that get lost and some missing Q_OBJECTs

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    10c266a View commit details
    Browse the repository at this point in the history

  77. ran precommit manually

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    05f6a46 View commit details
    Browse the repository at this point in the history

  78. moved qopengl/shaders

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    fac0bdc View commit details
    Browse the repository at this point in the history

  79. minor changes and improved comments based on review

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    9114f54 View commit details
    Browse the repository at this point in the history

  80. count beats without calling numBeatsInRange

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    09f21f7 View commit details
    Browse the repository at this point in the history

  81. added missing use of matrixForWidgetGeometry

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    51cd5c0 View commit details
    Browse the repository at this point in the history

  82. fix clazy

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    38f53ee View commit details
    Browse the repository at this point in the history

  83. fix typo

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    a5afde1 View commit details
    Browse the repository at this point in the history

  84. better fix for flickering when resizing

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    4f4909e View commit details
    Browse the repository at this point in the history

  85. use QApplication::sendEvent instead of handleWindowFromEvent. this is… 

    … cleaner and solves the key events not reaching the event filter
    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    e1509e4 View commit details
    Browse the repository at this point in the history

  86. correctly calculate max amount of preroll triangles

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    a847b9b View commit details
    Browse the repository at this point in the history

  87. pass tooltip for waveformviewer to waveform widget

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    ae7fe08 View commit details
    Browse the repository at this point in the history

  88. properly forward events to wwaveformviewer, fixes cue mark hovering

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    4145abc View commit details
    Browse the repository at this point in the history

  89. forward events to wglwaveformwidget to wwaveformviewer

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    41b692f View commit details
    Browse the repository at this point in the history

  90. avoid flickering with legacy gl waveform widgets

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    ed84c8e View commit details
    Browse the repository at this point in the history

  91. postpone extra render to avoid flicker until next paintGL

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    e1ec6fb View commit details
    Browse the repository at this point in the history

  92. glwaveformrenderbackground replacement for waveformrenderbackground u… 

    …sing glClear to clear waveform widget
    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    33ec185 View commit details
    Browse the repository at this point in the history

  93. using glwaveformrendererbackground to draw background for legacy gl w… 

    …aveform widgets (adapted solution from PR 11523)
    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    8e90e2a View commit details
    Browse the repository at this point in the history

  94. moved folders and namespaces

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    a2a1c3c View commit details
    Browse the repository at this point in the history

  95. cleanup and formatting post rebase on 2.4, compile allshader widgets … 

    …also with QGLWidget and use shader based vumeters and spinnys by default
    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    8a47d05 View commit details
    Browse the repository at this point in the history

  96. fix pre-commit

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    16c05e6 View commit details
    Browse the repository at this point in the history

  97. simplified handling events from openglwindow, removed unneeded layer … 

    …wglwaveformwidget, avoid infinite recursion with drag move and drag leave events
    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    7c078ca View commit details
    Browse the repository at this point in the history

  98. removed unnecessary windowExposed, as we can rely on initializeGL to … 

    …know when the context is available
    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    968b279 View commit details
    Browse the repository at this point in the history

  99. use local var

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    c45043e View commit details
    Browse the repository at this point in the history

  100. set openglwindow event target to waveformviewer

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    61589ed View commit details
    Browse the repository at this point in the history

  101. Revert "set openglwindow event target to waveformviewer" 

    This reverts commit 2b41420.
    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    5c6c774 View commit details
    Browse the repository at this point in the history

  102. fixes post-rebase

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    b3f0ed8 View commit details
    Browse the repository at this point in the history

  103. use custom mechanism to deliver drag&drop events coming from the QOpe… 

    …nGLWindow
    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    18378e4 View commit details
    Browse the repository at this point in the history

  104. formatting

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    c4093c6 View commit details
    Browse the repository at this point in the history

  105. fixed bug in Paintable::toImage

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    6d033dd View commit details
    Browse the repository at this point in the history

  106. dont create qopengltexture without valid context or with null images

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    3111e6b View commit details
    Browse the repository at this point in the history

  107. use glsl spinnies and vumeters with qopengl only

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    e25f0f4 View commit details
    Browse the repository at this point in the history

  108. remove unnecessary includes

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    298033e View commit details
    Browse the repository at this point in the history

  109. use p prefix for pointers

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    60132d5 View commit details
    Browse the repository at this point in the history

  110. call WGLWidget resizeGL with devicePixelRatio applied, to mimic QGLWi… 

    …dget, use the argument to resizeGL when resizing the waveformrendermark
    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    bf72f07 View commit details
    Browse the repository at this point in the history

  111. added helper that creates qopengltexture and sets linear filtering

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    1631d50 View commit details
    Browse the repository at this point in the history

  112. removed spurious makeCurrentIfNeeded, postpone call to slotLoadTrack … 

    …for initial player to setup, to avoid calling a virtual (indirectly) from the constructor
    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    e10dab9 View commit details
    Browse the repository at this point in the history

  113. set the context when calling WGLWidget::resizeGL, to mimic QGLWidget

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    0fbf597 View commit details
    Browse the repository at this point in the history

  114. apply devicePixelRatio when scaling images to widget size (reducing c… 

    …ode duplication with helper scaleToSize), regenerate the textures after the images have been resized
    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    4ec3fba View commit details
    Browse the repository at this point in the history

  115. calculate the visual split position just like the play position

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    a606587 View commit details
    Browse the repository at this point in the history

  116. dont use allshaders waveforms with QOPENGL=OFF

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    d01787c View commit details
    Browse the repository at this point in the history

  117. fix for style not being applied correctly to WWidgetGroup when the vi… 

    …sible property has a binding which resulted in wrong sized children, e.g wspinny inside LateNights SpinnyCoverContainer_Small
    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    63cdb15 View commit details
    Browse the repository at this point in the history

  118. compile and show qt waveforms only when MIXXX_USE_QOPENGL is not set

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    27d9a79 View commit details
    Browse the repository at this point in the history

  119. tentative fix for spinny positions scaled drawing

    @m0dB
    m0dB committed May 26, 2023
    Configuration menu
    Copy the full SHA
    67a59af View commit details
    Browse the repository at this point in the history

Commits on May 27, 2023

  1. clear WInitialGLWidget

    @m0dB
    m0dB committed May 27, 2023
    Configuration menu
    Copy the full SHA
    63a626d View commit details
    Browse the repository at this point in the history

  2. added missing calls to doneCurrent for correctness

    @m0dB
    m0dB committed May 27, 2023
    Configuration menu
    Copy the full SHA
    5a69bc3 View commit details
    Browse the repository at this point in the history

  3. clear winitialglwidget in its paintGL

    @m0dB
    m0dB committed May 27, 2023
    Configuration menu
    Copy the full SHA
    670d4dd View commit details
    Browse the repository at this point in the history