Don't reject file metadata Keys values with non Minor/Major scales. #11001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daschuer
force-pushed
the
gh10995
branch
3 times, most recently
from
a2cf5b7
to
8b0b8c6
Compare
… conditions Like 8D which can be "Db Dur" or "D dorian"
… conditions Like 8D which can be "Db Dur" or "D dorian"
|
Rebase on 2.3 to make CI work. |
Swiftb0y
requested changes
Aug 7, 2023
Co-authored-by: Swiftb0y <12380386+Swiftb0y@users.noreply.github.com>
|
Done. Thank you for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #10995
It allows to read keys entries created by the Rapid evolution "detailed key mode"
"Ab ionian" or "04I"
In Mixxx they are displayed as a compatible Minor/Major key.