-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JACK buffer size fix. #11121
JACK buffer size fix. #11121
Commits on Dec 6, 2022
-
Fix condition in JACK backend check
`m_deviceInfo->hostApi` is an index in the list of supported APIs on this platform. So on Linux 0 is ALSA, 2 is JACK. This is also mentioned in the comment on the `hostApi` field. We should be checking the device type ID instead, as is done elsewhere in the code. This fixes the buffer size when using JACK clients. With JACK the buffer size should be coming from the server (and PortAudio chops it up into 1024 sample blocks if it's larger). Before this change it would use the now grayed out latency value set for the previous audio backend before switching to JACK (defaulting to 1024 samples).
Configuration menu - View commit details
-
Copy full SHA for c2b1af8 - Browse repository at this point
Copy the full SHA c2b1af8View commit details -
Replace m_framesPerBuffer uses with runtime size
In any operation that works with audio buffers passed from PortAudio. This is needed because PortAudio may pass us buffers that are smaller or larger than the size we request. And when using JACK the requested size is 0, which will cause PortAudio to pick a buffer size matching the JACK server.
Configuration menu - View commit details
-
Copy full SHA for 82c7f71 - Browse repository at this point
Copy the full SHA 82c7f71View commit details -
Use std::unique_ptr for FIFOs in PortAudio backend
The network backend already does this.
Configuration menu - View commit details
-
Copy full SHA for fefbfd2 - Browse repository at this point
Copy the full SHA fefbfd2View commit details
Commits on Dec 8, 2022
-
Configuration menu - View commit details
-
Copy full SHA for cfeffa7 - Browse repository at this point
Copy the full SHA cfeffa7View commit details -
renamed m_framesPerBuffer to m_configFramesPerBuffer
to clarify that thisis not the actually used value. The actual value is passied via every audi callback.
Configuration menu - View commit details
-
Copy full SHA for 1451803 - Browse repository at this point
Copy the full SHA 1451803View commit details -
Configuration menu - View commit details
-
Copy full SHA for b1b14b1 - Browse repository at this point
Copy the full SHA b1b14b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f97592 - Browse repository at this point
Copy the full SHA 8f97592View commit details -
dispose m_iBufferSize and use always the callback value as parameter
This clarifies that the value is a subject of change in case of JACK
Configuration menu - View commit details
-
Copy full SHA for 4c1eb24 - Browse repository at this point
Copy the full SHA 4c1eb24View commit details -
Always use the real framesPerBuffer value received via the callback
This allows following the server buffer size that is not always const.
Configuration menu - View commit details
-
Copy full SHA for e52de39 - Browse repository at this point
Copy the full SHA e52de39View commit details -
Configuration menu - View commit details
-
Copy full SHA for 75d0e29 - Browse repository at this point
Copy the full SHA 75d0e29View commit details -
Configuration menu - View commit details
-
Copy full SHA for f1bc670 - Browse repository at this point
Copy the full SHA f1bc670View commit details -
Configuration menu - View commit details
-
Copy full SHA for 096089d - Browse repository at this point
Copy the full SHA 096089dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d24c26 - Browse repository at this point
Copy the full SHA 6d24c26View commit details -
Configuration menu - View commit details
-
Copy full SHA for 705e097 - Browse repository at this point
Copy the full SHA 705e097View commit details -
Configuration menu - View commit details
-
Copy full SHA for e15cda3 - Browse repository at this point
Copy the full SHA e15cda3View commit details -
Configuration menu - View commit details
-
Copy full SHA for b48e06d - Browse repository at this point
Copy the full SHA b48e06dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 185a681 - Browse repository at this point
Copy the full SHA 185a681View commit details -
Configuration menu - View commit details
-
Copy full SHA for 44fa755 - Browse repository at this point
Copy the full SHA 44fa755View commit details
Commits on Dec 9, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 32379a6 - Browse repository at this point
Copy the full SHA 32379a6View commit details
Commits on Dec 16, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 31ba28e - Browse repository at this point
Copy the full SHA 31ba28eView commit details
Commits on Jan 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f49bf12 - Browse repository at this point
Copy the full SHA f49bf12View commit details