Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JACK buffer size fix. #11121

Merged
merged 21 commits into from
Feb 4, 2023
Merged

Commits on Dec 6, 2022

  1. Fix condition in JACK backend check

    `m_deviceInfo->hostApi` is an index in the list of supported APIs on
    this platform. So on Linux 0 is ALSA, 2 is JACK. This is also mentioned
    in the comment on the `hostApi` field. We should be checking the device
    type ID instead, as is done elsewhere in the code.
    
    This fixes the buffer size when using JACK clients. With JACK the buffer
    size should be coming from the server (and PortAudio chops it up into
    1024 sample blocks if it's larger). Before this change it would use the
    now grayed out latency value set for the previous audio backend before
    switching to JACK (defaulting to 1024 samples).
    robbert-vdh committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    c2b1af8 View commit details
    Browse the repository at this point in the history
  2. Replace m_framesPerBuffer uses with runtime size

    In any operation that works with audio buffers passed from PortAudio.
    This is needed because PortAudio may pass us buffers that are smaller or
    larger than the size we request. And when using JACK the requested size
    is 0, which will cause PortAudio to pick a buffer size matching the JACK
    server.
    robbert-vdh committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    82c7f71 View commit details
    Browse the repository at this point in the history
  3. Use std::unique_ptr for FIFOs in PortAudio backend

    The network backend already does this.
    robbert-vdh committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    fefbfd2 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2022

  1. Configuration menu
    Copy the full SHA
    cfeffa7 View commit details
    Browse the repository at this point in the history
  2. renamed m_framesPerBuffer to m_configFramesPerBuffer

    to clarify that thisis not the actually used value. The actual value is
    passied via every audi callback.
    daschuer committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    1451803 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b1b14b1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8f97592 View commit details
    Browse the repository at this point in the history
  5. dispose m_iBufferSize and use always the callback value as parameter

    This clarifies that the value is a subject of change in case of JACK
    daschuer committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    4c1eb24 View commit details
    Browse the repository at this point in the history
  6. Always use the real framesPerBuffer value received via the callback

    This allows following the server buffer size that is not always const.
    daschuer committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    e52de39 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    75d0e29 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    f1bc670 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    096089d View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    6d24c26 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    705e097 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    e15cda3 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    b48e06d View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    185a681 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    44fa755 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2022

  1. Remove unused variable

    daschuer committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    32379a6 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2022

  1. Configuration menu
    Copy the full SHA
    31ba28e View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2023

  1. Configuration menu
    Copy the full SHA
    f49bf12 View commit details
    Browse the repository at this point in the history