Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EffectSlot::swapParameters: ignore no-op, e.g. after aborted drag (drop on itself) #11242

Merged
merged 1 commit into from
Feb 3, 2023
Merged

EffectSlot::swapParameters: ignore no-op, e.g. after aborted drag (drop on itself) #11242

merged 1 commit into from
Feb 3, 2023

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Feb 3, 2023

No description provided.

daschuer
daschuer approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@daschuer daschuer merged commit 3f6876f into mixxxdj:2.4 Feb 3, 2023
@ronso0 ronso0 deleted the effect-param-swap-noop branch February 3, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ronso0 @daschuer