Unified range checking behavior for BeatJumpSize and BeatLoopSize between GUI-Widget and controller CO

[JoergAtGithub]

The check is moved therefore from the widget to the engine code.

Closes: #11203

[ronso0]

@JoergAtGithub I'll take a look soonish.

[ronso0]

except for some spots, LGTM

edit need to take a closer look at the tests, and a manual test is still pending

[ronso0]

I just did another manual test (with Shade btw) and I encountered some strange issues with the loop size spinbox:

• strange size reset (I couldn't reproduce it, occured only once during the first test):
  • loop size is 4
  • type 320, hit Enter (tracks are focused)
  • click on loop_double
  • = size was reset to 4??
• strange size clamping (could reproduce it during one session with different values 100-255 but not afterwards):
  • enter 321, hit Enter
  • click Up button = nothing happened ✔️
  • click Down key = resized to 160 1/2 ✔️
  • hit Up key = nothing happened ❌

Both issues occured with no tracks loaded though I think that shouldn't matter).
After that, everything worked as expected, both with keyboard Up/Down, spinbox buttons and double/halve COs. So maybe there's something wrong with the key events or spinbox buttons, idk, very mysterious.

[ronso0]

So basically, LGTM, ready for merged.
While trying to debug the isseus mentioned above I stumbled over this comment

mixxx/src/widget/wbeatspinbox.cpp

Lines 69 to 75 in 146f0bb

	// Curiously, m_valueControl.set() does not cause slotControlValueChanged
	// to execute for beatjump_size, so call QDoubleSpinBox::setValue in this function.
	m_valueControl.set(newValue);
	double coValue = m_valueControl.get();
	if (coValue != value()) {
	setValue(coValue);
	}

I did a quick test with some debug messages and I'm pretty sure this part can be removed to avoid the extra round so it's just

    // comment...
    m_valueControl.set(newValue);
    selectAll();

[JoergAtGithub]

Thanks for testing.
I aggree that

mixxx/src/widget/wbeatspinbox.cpp

Lines 72 to 75 in 146f0bb

	double coValue = m_valueControl.get();
	if (coValue != value()) {
	setValue(coValue);
	}

shouldn't be needed.
How should we proceed?

[ronso0]

Can you remove that snippet? Then I can press merge.

I cannot reproduce the issue I saw, and --looking at the code-- I have no idea where that should come from. Maybe concurrent calls to loopingcontrol due to the snippet above 🤷 (though it was the beatloop size not the beatjump size as the comment states)

[JoergAtGithub]

I removed these lines - and a short GUI test with Latenight showed the same correct behavior as before.

[ronso0]

Thanks for fixing this!