Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor convertWCStringToQString #11318

Merged

Conversation

Swiftb0y
Copy link
Member

@Swiftb0y Swiftb0y commented Mar 1, 2023

Alternative to #11310
Previous discussion: Swiftb0y@b0004db

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@daschuer
Copy link
Member

daschuer commented Mar 1, 2023

@JoergAtGithub
Is it OK for you to merge this PR instead of yours?

@JoergAtGithub
Copy link
Member

I tested this using my Windows 11 laptop - all works as expected!

@JoergAtGithub JoergAtGithub merged commit 03d2710 into mixxxdj:2.4 Mar 1, 2023
@JoergAtGithub
Copy link
Member

Thank you!

@Swiftb0y
Copy link
Member Author

Swiftb0y commented Mar 1, 2023

Thank you

@Swiftb0y Swiftb0y deleted the refactor/convertWCStringToQString2 branch March 1, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants