Traktor S3: Fix script startup #11463
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This data hack no longer works due to the the controller performance changes, and it turns out it is not needed, so remove it.
|
Seems it's the same issue as #11461 ? |
Swiftb0y
added a commit
to Swiftb0y/mixxx
that referenced
this pull request
Apr 11, 2023
Fixes mixxxdj#11461, alternative to mixxxdj#11463
Swiftb0y
added a commit
to Swiftb0y/mixxx
that referenced
this pull request
Apr 12, 2023
Fixes mixxxdj#11461, alternative to mixxxdj#11463
Swiftb0y
added a commit
to Swiftb0y/mixxx
that referenced
this pull request
Apr 12, 2023
Fixes mixxxdj#11461, alternative to mixxxdj#11463
|
I think those are the only two affected mappings. |
|
it looks like an alternative fix has been pulled in, but at least on the S3 the hack was totally unnecessary. I don't have an S2 to hack but I suspect it is also unneeded there. |
|
PR #11470 is merged now. |
|
Superseeded by #11470 IIUC, closing. Feel free to reopen if this is still needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This data hack no longer works due to the the controller performance changes, and it turns out it is not needed, so remove it.
This will be eventually obviated by #11199 but this controller is broken under 2.4 currently.