Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pref > Mixer: apply & save settings only in slotApply(), fix bugs, improve UX #11527

Merged
merged 53 commits into from
Oct 16, 2023
Merged

Pref > Mixer: apply & save settings only in slotApply(), fix bugs, improve UX #11527

merged 53 commits into from
Oct 16, 2023

Commits on Jun 30, 2023

  1. Pref Mixer, ui: set xfader button group in ui file

    @ronso0
    ronso0 committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    f888df7 View commit details
    Browse the repository at this point in the history

  2. Pref Mixer, ui: fix widget tab focus order

    @ronso0
    ronso0 committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    c400306 View commit details
    Browse the repository at this point in the history

  3. Pref Mixer, xFader: update settings only when touching xfader widgets

    @ronso0
    ronso0 committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    ca18756 View commit details
    Browse the repository at this point in the history

  4. Pref Mixer, xfader: don't store pointer to curve scene

    @ronso0
    ronso0 committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    f230382 View commit details
    Browse the repository at this point in the history

  5. Pref Mixer: read config only in slotUpdate() pt I

    @ronso0
    ronso0 committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    14f6811 View commit details
    Browse the repository at this point in the history

  6. Pref Mixer, bypass EQ: add bool for checkbox state, apply 'only in sl… 

    …otApply()
    @ronso0
    ronso0 committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    555b02d View commit details
    Browse the repository at this point in the history

  7. Pref Mixer, deck EQ & QuickEffects: prevent unneeded reload during init

    @ronso0
    ronso0 committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    9554e84 View commit details
    Browse the repository at this point in the history

  8. Pref Mixer: improve function names, remove b prefix from bools, comments

    @ronso0
    ronso0 committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    f731e9d View commit details
    Browse the repository at this point in the history

  9. Pref Mixer: apply settings only in slotApply(), except Main EQ

    @ronso0
    ronso0 committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    96929a0 View commit details
    Browse the repository at this point in the history

  10. Pref Mixer, main EQ: rework loading, updating & saving

    @ronso0
    ronso0 committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    770c643 View commit details
    Browse the repository at this point in the history

  11. Pref Mixer, main EQ: add checkbox to apply parameter changes instantly

    @ronso0
    ronso0 committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    6b248d5 View commit details
    Browse the repository at this point in the history

  12. Pref Mixer, main EQ: tweak parameter slider steps and value labels

    @ronso0
    ronso0 committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    2fdaee3 View commit details
    Browse the repository at this point in the history

  13. Pref Mixer, EQ shelves: add checkbox to apply shelves instantly

    @ronso0
    ronso0 committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    b4c880b View commit details
    Browse the repository at this point in the history

  14. Pref Mixer, EQ shelves: fix update, improve precision, avoid round tr… 

    …ip errors

Increase slider range (int, linear) for more precision when calculating the corresponding EQ frequency
(double, exponential) and vice versa.
Previously there was a round-trip rounding issue that would decrease certain high EQ frequencies on each update
until they'd settle at certain values that are appearantly not affected. This was also noticeable when recalling
the defaults (250 Hz, 2500 Hz), which resulted in 2484 Hz and 246 Hz.
    @ronso0
    ronso0 committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    21d5f5e View commit details
    Browse the repository at this point in the history

  15. Pref Mixer, deck EQ & QuickEffects: rework update & save 

    load EQ effects from config only during init, load from effects engine for later updates
    @ronso0
    ronso0 committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    f6c4435 View commit details
    Browse the repository at this point in the history

  16. Pref Mixer, deck EQ & QuickEffects: disable non-EQ items if 'EQs only… 

    …' is checked
    @ronso0
    ronso0 committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    c4e4fe1 View commit details
    Browse the repository at this point in the history

  17. Pref Mixer: add tooltips for deck & main EQ effects

    @ronso0
    ronso0 committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    f1e1a6a View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2023

  1. Pref Mixer: fix UX when checking 'Same EQ for all decks'

    @ronso0
    ronso0 committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    2f5fd9e View commit details
    Browse the repository at this point in the history

  2. Pref Mixer: migrate bool options from yes|no to 1|0

    @ronso0
    ronso0 committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    0d2f732 View commit details
    Browse the repository at this point in the history

  3. Pref Mixer: remove obsolete includes, some comments

    @ronso0
    ronso0 committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    82b3fc0 View commit details
    Browse the repository at this point in the history

  4. Pref Mixer: p prefix for widget pointers

    @ronso0
    ronso0 committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    e82d50b View commit details
    Browse the repository at this point in the history

  5. Pref Mixer: use PollingControlProxy for EQ shelve controls

    @ronso0
    ronso0 committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    d3d18cb View commit details
    Browse the repository at this point in the history

  6. Pref Mixer, EQ shelves: instant apply on change, write to config in s… 

    …lotApply()
    @ronso0
    ronso0 committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    41c4938 View commit details
    Browse the repository at this point in the history

  7. Pref Mixer, main EQ: apply instantly, store to config in slotApply()

    @ronso0
    ronso0 committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    0a3c57f View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2023

  1. Pref Mixer: fix main EQ parameter precision

    @ronso0
    ronso0 committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    37bddab View commit details
    Browse the repository at this point in the history

  2. Pref Mixer: fix EQ shelves display precision

    @ronso0
    ronso0 committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    742ca3d View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2023

  1. move EQ corner ConfigKey strings to effects/defs.h, adjust Pref Mixer 

    also don't store coarse EQ frequency corners in config anymore
    @ronso0
    ronso0 committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    88a7f37 View commit details
    Browse the repository at this point in the history

  2. Pref Mixer: constants for ConfigKeys

    @ronso0
    ronso0 committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    21667b6 View commit details
    Browse the repository at this point in the history

  3. Pref Mixer: get default QuickEffect name from its effect manifest

    @ronso0
    ronso0 committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    2f8534f View commit details
    Browse the repository at this point in the history

  4. use PollingControlProxy for EQ corner frequency controls

    @ronso0
    ronso0 committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    26b952c View commit details
    Browse the repository at this point in the history

  5. EQ utils: add TODO to update tr string after 2.4 release

    @ronso0
    ronso0 committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    c8d98b2 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. Merge remote-tracking branch 'mixxx/2.4' into pref-mixer-apply

    @ronso0
    ronso0 committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    89acb4e View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2023

  1. Merge remote-tracking branch 'mixxx/2.4' into pref-mixer-apply

    @ronso0
    ronso0 committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    0aea69e View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2023

  1. Merge remote-tracking branch 'mixxx/2.4' into pref-mixer-apply

    @ronso0
    ronso0 committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    579792f View commit details
    Browse the repository at this point in the history

  2. Pref Mixer: polish comments, remove obsolete TODOs, add DEBUG_ASESERT

    @ronso0
    ronso0 committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    930e42a View commit details
    Browse the repository at this point in the history

  3. EffectsManager: add getQuickEffectChain() helper

    @ronso0
    ronso0 committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    ce925d9 View commit details
    Browse the repository at this point in the history

  4. Pref Mixer: use EffectsManager::getQuickEffectChain()

    @ronso0
    ronso0 committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    d3ca182 View commit details
    Browse the repository at this point in the history

  5. Pref Mixer: a few DEBUG_ASSERT instead of VERIFY_OR_...

    @ronso0
    ronso0 committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    0437f34 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2023

  1. EQ effects tooltip: point to new Mixer page for adjusting the EQ shelves

    @ronso0
    ronso0 committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    5298b85 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2023

  1. Merge remote-tracking branch 'mixxx/2.4' into pref-mixer-apply

    @ronso0
    ronso0 committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    f2abc89 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. Pref Mixer: constants for xfader ConfigKeys

    @ronso0
    ronso0 committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    0ca9701 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. EQ effects: remove empty destructors

    @ronso0
    ronso0 committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    c439051 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. Pref Mixer: use parented_ptr for xfader QGraphicsScene, reuse scene

    @ronso0
    ronso0 committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    e07c3c2 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2023

  1. Pref Mixer: polish xfader graph, smooth lines, style it like it's 202… 

    …3 (not 1990 ;)
    @ronso0
    ronso0 committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    20bd4fa View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2023

  1. Merge remote-tracking branch 'mixxx/2.4' into pref-mixer-apply

    @ronso0
    ronso0 committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    6f20086 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2023

  1. Pref Mixer: don't use indexOf(QComboBox*) in for loops

    @ronso0
    ronso0 committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    17422ed View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. Pref Mixer: use parented_ptr for all widgets created on request

    @ronso0
    ronso0 committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    5aa6b32 View commit details
    Browse the repository at this point in the history

  2. Pref Mixer: contruct combobox tooltips with string args

    @ronso0
    ronso0 committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    84ddc77 View commit details
    Browse the repository at this point in the history

  3. Pref Mixer: qAsConst -> std::as_const

    @ronso0
    ronso0 committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    4c1e867 View commit details
    Browse the repository at this point in the history

  4. Pref Mixer: auto* + simpler combobox item deactivation

    @ronso0
    ronso0 committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    c222ed4 View commit details
    Browse the repository at this point in the history

  5. Pref Mixer: more efficient EQ list splitting EQs / non-EQs 

    Co-authored-by: Swiftb0y <12380386+Swiftb0y@users.noreply.github.com>
    @ronso0 @Swiftb0y
    ronso0 and Swiftb0y committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    8e571ee View commit details
    Browse the repository at this point in the history

  6. Pref Mixer: show effects' display name, separate EQs / non-EQs

    @ronso0
    ronso0 committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    2132b97 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. Merge remote-tracking branch 'mixxx/2.4' into pref-mixer-apply

    @ronso0
    ronso0 committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    268e278 View commit details
    Browse the repository at this point in the history