Lib sidebar: right click selection fixes #11574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Note this is just a workaround for an inconsistency created by slotJoinWithPrevious. That slot uses m_pPlaylistTableModel to load a playlist while there is a different sidebar item selected.
ronso0
force-pushed
the
lib-sidebar-right-click-selection_fixes
branch
from
ed6a4b9
to
a58f192
Compare
|
Woo, done. I did a lot of testing and now the sidebar selection is kept if possible, and the sidebar selection and track view are always in sync. Furthermore I added a "Mark tracks played" sidebar action to fix #8948 (for this and 'Join with previous' I added a new method to track.cpp). |
daschuer
requested changes
Jun 5, 2023
| @@ -66,6 +64,12 @@ SetlogFeature::SetlogFeature( | |||
| this, | |||
| &SetlogFeature::slotJoinWithPrevious); | |||
|
|
|||
| m_pMarkTracksPlayedAction = new QAction(tr("Mark all tracks played)"), this); | |||
There was a problem hiding this comment.
Suggested change
| m_pMarkTracksPlayedAction = new QAction(tr("Mark all tracks played)"), this); | |
| m_pMarkTracksPlayedAction = new QAction(tr("Mark all tracks played"), this); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up for #11208 with small UX fixes