Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

History: restore menu action "Remove from playlist" #11591

Merged
merged 1 commit into from Jun 5, 2023
Merged

History: restore menu action "Remove from playlist" #11591

merged 1 commit into from Jun 5, 2023

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented May 25, 2023

The "Remove" action is really useful to clean up set lists, for example to remove

  • tracks from the soundcheck after forgetting about 'Start new' (split history)
  • played tracks that didn't make it into the main mix (recording) in a back-to-back session
  • duplicate tracks that were not filtered

And it would comply with disallowing rewriting the history. 'Forgetting' events is different from creating new ones : )

Fixes #10974

@ronso0 ronso0 added this to the 2.4.0 milestone May 25, 2023
@ronso0 ronso0 marked this pull request as ready for review May 25, 2023 11:33
@ronso0 ronso0 linked an issue May 25, 2023 that may be closed by this pull request
Re-add "Remove" to History track menu #10974
Closed
daschuer
daschuer approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works good. Thank you.

@daschuer daschuer merged commit 423589c into mixxxdj:2.4 Jun 5, 2023
13 checks passed
@ronso0 ronso0 deleted the remove-from-history branch June 5, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
library
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

Re-add "Remove" to History track menu
2 participants
@ronso0 @daschuer