Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numark DJ2GO2 Touch: Correct sysex message to get control settings at startup #11659

Merged
merged 2 commits into from Jun 18, 2023
Merged

Numark DJ2GO2 Touch: Correct sysex message to get control settings at startup #11659

merged 2 commits into from Jun 18, 2023

Conversation

burnsak
Copy link
Contributor

@burnsak burnsak commented Jun 14, 2023

Fixes #11658

@JoergAtGithub
Copy link
Member

Welcome and thanks for improving this! Please sign the Mixxx Contributor Agreement and comment here when you have done so. It gives us permission to distribute your contribution under the GPL v2 or later license and the Apple Mac App Store. It is also helpful for us to have contact information for contributors in case we may need it in the future.

@JoergAtGithub
Copy link
Member

@tandy-1000 Could you test, if these Numark DJ2GO2 Touch mapping changes works with your device too? Especially the sysex message can only be tested by someone, who has such a controller.

@burnsak
Copy link
Contributor Author

burnsak commented Jun 14, 2023

Welcome and thanks for improving this! Please sign the Mixxx Contributor Agreement and comment here when you have done so. It gives us permission to distribute your contribution under the GPL v2 or later license and the Apple Mac App Store. It is also helpful for us to have contact information for contributors in case we may need it in the future.

I signed the agreement

@tandy-1000
Copy link
Contributor

Works for me!

@JoergAtGithub
Copy link
Member

@burnsak Thank you, for improving this mapping!
@tandy-1000 Thank you, for testing the improved mapping!

@JoergAtGithub JoergAtGithub merged commit 0c90852 into mixxxdj:2.3 Jun 18, 2023
8 checks passed
@ronso0 ronso0 changed the title Correct sysex message to get control settings at startup Numark DJ2GO2 Touch: Correct sysex message to get control settings at startup Jun 18, 2023
@burnsak burnsak deleted the fix_numark_dj2go2touch branch June 19, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants