Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add settings directory link to Help menu #11670

Merged
merged 1 commit into from Jun 20, 2023

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Jun 20, 2023

A menu item is a real shortcut compared to clicking the button in Pref > Library and or pasting the path into a file manager bar.

Closes #11667

@ronso0 ronso0 added this to the 2.4.0 milestone Jun 20, 2023
@github-actions github-actions bot added the ui label Jun 20, 2023
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Swiftb0y Swiftb0y merged commit e59b579 into mixxxdj:2.4 Jun 20, 2023
13 checks passed
@ronso0
Copy link
Member Author

ronso0 commented Jun 20, 2023

Whooop, that was a quick fix : )

@ronso0 ronso0 deleted the menu-settings-dir-link branch June 20, 2023 11:19
@m0dB
Copy link
Contributor

m0dB commented Jun 23, 2023

Unfortunately this PR has broken opening the Preferences dialog on macOS.

Selecting the menu item, or using the shortkey, has no effect. When I comment out the code introduced by this PR, it works as expected.

It looks like the &WMainMenuBar::showPreferences signal is never emitted. I connected &WMainMenuBar::showAbout to &MixxxMainWindow::slotOptionsPreferences to check, and with that the About menu item triggers the preferences dialog just fine.

@m0dB
Copy link
Contributor

m0dB commented Jun 23, 2023

I found the cause: the use of &Settings here:

QString settingsDirTitle = tr("&Settings directory");      

It looks like this interferes with the Preferences menu on macOS (I guess due to the transition from Preferences to Settings). If I change this to

QString settingsDirTitle = tr("&User settings directory"); 

the preference menu starts working again. So it looks like with this PR the Preferences menu triggers this pHelpSettingsDir action instead (which BTW, doesn't seem to do anything on macOS)

@ronso0 @Swiftb0y how to proceed? Will you take care of this or do you want me to create a PR?

@m0dB
Copy link
Contributor

m0dB commented Jun 23, 2023

@ronso0 @Swiftb0y This PR fixes both issues. This PR should IMO be merged ASAP as having no preferences menu on macOS is pretty bad.

#11679

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants