Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library sidebar: focus selected item for all keypress events #11712

Merged
merged 1 commit into from Jul 10, 2023

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Jul 5, 2023

incl. those handled by QTreeView (Right for example)

fixes a small regression introduced by #11208
if a unselected item was right-clicked (to rename or whatever), then switched to another window and back to Mixxx, navigation keypresses not handled by Mixxx would reset the cursor to Tracks.

@github-actions github-actions bot added the ui label Jul 5, 2023
@ronso0 ronso0 added this to the 2.4.0 milestone Jul 5, 2023
@ronso0 ronso0 changed the title Libryr sidebar: focus selected item for all keypress events Library sidebar: focus selected item for all keypress events Jul 8, 2023
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I can confirm the fix.

@daschuer daschuer merged commit 2cb54d9 into mixxxdj:2.4 Jul 10, 2023
9 of 11 checks passed
@ronso0 ronso0 deleted the lib-sidebar-keyboard-fixes branch July 10, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants