Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add LateNight (64 Samplers) #11715

Merged
merged 3 commits into from Jul 19, 2023
Merged

add LateNight (64 Samplers) #11715

merged 3 commits into from Jul 19, 2023

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Jul 6, 2023 •
edited

superseeds #11105

Users can now choose between 4, 8, 16, 32, 48 or 64 samplers.

  • add previews with many samplers

@ronso0 ronso0 mentioned this pull request Jul 6, 2023
Closed
@ronso0 ronso0 changed the base branch from main to 2.4 July 6, 2023 15:59
daschuer
daschuer approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Do you want to add the screenshot before merge or in an a separate action for all skins?

@ronso0
Copy link
Member Author

ronso0 commented Jul 19, 2023

hmm, true, we can merge now and I'll add the screenshots later on.

@daschuer
Copy link
Member

OK, Thank you.

@daschuer daschuer merged commit cedb39d into mixxxdj:2.4 Jul 19, 2023
9 of 11 checks passed
@ronso0 ronso0 deleted the late64 branch July 19, 2023 21:15
@ronso0
Copy link
Member Author

ronso0 commented Jul 25, 2023

pushed a fixup cf22f6c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
code quality library skins ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ronso0 @daschuer