Protobuf: Use package provided config if available #11751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daschuer
force-pushed
the
protobuf-config
branch
from
2142638
to
45a3187
Compare
|
The workaround have fixed the compile-error for me. (EndeavourOS / Archlinux) |
|
I have tested this with an experimental vcpkg environment including v23.4. |
daschuer
force-pushed
the
protobuf-config
branch
from
b4cae36
to
fb89297
Compare
daschuer
force-pushed
the
protobuf-config
branch
from
fb89297
to
b48611f
Compare
|
@winter1967 I have improved that PR for Windows and macOS. |
@daschuer - I just compiled this PR (GIT Version: 2.3.5-27-gb48611f170 (protobuf-config)) without issues on EndeavourOS |
|
Great. Who can review and merge this than? |
Swiftb0y
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for a probably outdated CMake Modul.
This aims to fix linking with protobuf v23.4 and the required Abseil.
https://mixxx.zulipchat.com/#narrow/stream/247620-development-help/topic/Compiling.20Error.20on.20Arch