Pref Controller: avoid scrollbars in I/O tabs if Info tab exceeds page height #11756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e height Scroll only Info tab if required while I/O tabs still fit the page. Otherwise the I/O tabs expand equally and Add, Remove, Clear buttons are hidden.
|
I have just tested it on top of the 2.3 branch, but I cannot spot the difference. I have probably not yet understand what the issue is. At least I see no regression. |
|
The Info tab correctly expands if the content doesn't fit the page. This PR fixes that: Info may expand, In/Out are fit: |
|
Strange, I cannot confirm the issue here on Ubuntu Focal. But since there is an evidence that it is fixed on your side and I do not see a regression, it should be save to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scroll only Info tab if required while I/O tabs still fit the page. Otherwise the I/O tabs expand equally and Add, Remove, Clear buttons are hidden.
(backported 2.4 fix, didn't check this locally yet)