Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) WTrackProperty: focus double-clicked property field in DlgTrackInfo #11804

Merged
merged 1 commit into from Aug 10, 2023

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Aug 10, 2023

Embarrassing that I didn't test the title label and assumed QHash::end() would return QWidget nullptr.

Closes #11802

src/library/dlgtrackinfo.cpp Outdated Show resolved Hide resolved
@ronso0 ronso0 force-pushed the track-info-double-click-fix branch from a00a4a8 to f20eafb Compare August 10, 2023 01:06
@ronso0 ronso0 force-pushed the track-info-double-click-fix branch from f20eafb to 72532b5 Compare August 10, 2023 01:06
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Swiftb0y Swiftb0y merged commit 42864d2 into mixxxdj:2.4 Aug 10, 2023
13 checks passed
@stefan-franz
Copy link

Hmmm.....i'm right that it is fixed? (because of closed the the issues...?) I'm a bit confused.....
If it is fixed, there is still no update available for Linux Mint (over ppa)

@ronso0 ronso0 deleted the track-info-double-click-fix branch August 10, 2023 11:57
@ronso0
Copy link
Member Author

ronso0 commented Aug 10, 2023

I thought you're around for long and know that a fix lands in the build after the respective PR was merged.
"fixed by #[PR number]" means the PR adds the code to fix a certain issue. Until that is merged, built, and the build being pushed to the ppa you can test with the CI builds as explained here https://github.com/mixxxdj/mixxx/wiki/Testing

Building takes a while, just check the ppa in an hour or so.

@stefan-franz
Copy link

Thanks - i didn't know that. But now it works. Update was found by Linux Mint and all works.
Thank you very much to all involved for that fast fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants