Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete obsolete -platform xcb args #11805

Merged
merged 1 commit into from Aug 11, 2023
Merged

Delete obsolete -platform xcb args #11805

merged 1 commit into from Aug 11, 2023

Conversation

uklotzde
Copy link
Contributor

Enforcing Mixxx to use XWayland on Wayland now causes bugs like #11576.

I also don't experience any issue with the legacy GL/GLSL waveform shaders.

@uklotzde
Copy link
Contributor Author

Otherwise I would need to manually patch this out.

Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I forgot we decided to do this.

@Swiftb0y
Copy link
Member

just fyi there is a small visual glitch with the (GL) waveform variants. My guess is that some blend setting or similar is wrong resulting in out-of-range values because the resulting waveforms look blown out onscreen but the screenshot produced by gnome looks entirely different. The difference probably comes from the GPU just clamping the values while the compositor (or whatever is responsible for screenshots) just ignores the integer part.
RGB (GL) waveforms seemingly wrapped

In either case, nothing blocking this PR but we'll probably get reports of people being on the GL waveforms from 2.3 even though they should switch to the (all-shaders) anyways. I guess would be a valid reason to remove the GL waveforms altogether?

@daschuer daschuer added this to the 2.4.0 milestone Aug 10, 2023
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.

@daschuer daschuer merged commit 7454f5e into mixxxdj:2.4 Aug 11, 2023
13 checks passed
@uklotzde uklotzde deleted the qt-platform branch September 4, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants