Fix calc of first beatgrid bar in Engine export #11815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr-smidge
commented
Aug 12, 2023
| @@ -143,7 +143,7 @@ bool tryGetBeatgrid(BeatsPointer pBeats, | |||
|
|
|||
| int numBeatsToCue = pBeats->numBeatsInRange(firstBeatPlayPos, cueBeatPlayPos); | |||
| const auto firstBarAlignedBeatPlayPos = pBeats->findNBeatsFromPosition( | |||
| cueBeatPlayPos, numBeatsToCue & ~0x3); | |||
| cueBeatPlayPos, -1 * (numBeatsToCue & ~0x3)); | |||
There was a problem hiding this comment.
What a blunder... this code has been unchanged for a long time, but it was mistakenly trying to find the first bar in the track by scanning forwards instead of backwards.
This resulted in the beatgrid being calculated more and more inaccurately the further forward the main cue point was in the track.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.