Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pref Mixer: fix reset of EQ auto-reset checkbox #11818

Merged
merged 1 commit into from Aug 12, 2023

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Aug 12, 2023

Closes #11817

slotApply() called too early during init.

Note that this page is still messy in terms of UX / consistency.
I won't do anymore quick fixes. I already fixed this bug (and others, see #11271) and improved UX in #11527. Let's merge that asap to finally clean up that page. There are no tr changes, hence it's even a 2.4.0 candidate.

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@daschuer daschuer merged commit dda78b8 into mixxxdj:2.4 Aug 12, 2023
13 checks passed
@ronso0 ronso0 deleted the pref-eq-reset-fix branch August 12, 2023 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Reset EQ on loading a new track" unchecked on every restart
2 participants