New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qt6: Use constInsert() template #11847

Merged

Swiftb0y merged 1 commit into mixxxdj:main from daschuer:qt6-build-checks-fix

Aug 21, 2023

Member

daschuer commented Aug 21, 2023

This is a follow up of #11701
Fortunately clazy is still complaining
https://github.com/daschuer/mixxx/actions/runs/5919227496/job/16049296854

Error: /home/runner/work/mixxx/mixxx/src/util/rangelist.cpp:41:32: error: Mixing iterators with const_iterators [-Wclazy-strict-iterators]
                intList.insert(insertPos, currentIndex);
                               ^
1 error generated.


          Use constInsert template

d024bec

daschuer requested a review from Swiftb0y

August 21, 2023 08:59

Swiftb0y approved these changes

View reviewed changes

Swiftb0y merged commit dfde28d into mixxxdj:main

13 checks passed

daschuer deleted the qt6-build-checks-fix branch

August 24, 2023 05:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment