DlgAbout: Add Qt version to the dialog #11862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwcd
commented
Aug 24, 2023
| @@ -78,8 +78,27 @@ | |||
| </item> | |||
| <item> | |||
| <layout class="QGridLayout" name="gridLayout"> | |||
| <item row="2" column="1"> | |||
| <widget class="QLabel" name="platform_label"> | |||
| <item row="0" column="0"> | |||
There was a problem hiding this comment.
I apologize for the slightly noisy diff: The markup was quite hard to read since rows/columns were in no recognizable order, therefore I've sorted them first. Reviewing commit-by-commit might be the easiest here.
There was a problem hiding this comment.
👍
good ol' QtCreator used to randomize item order when items were added/moved in the GUI editor and diffs were unreviewable, especially for large preferences pages.
Though, out if laziness I tried it lately and this seems to be fixed.
Co-authored-by: Swiftb0y <12380386+Swiftb0y@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small QoL improvement that adds the Qt version to the about dialog: