Effectchain tooltip #11902
Effectchain tooltip #11902
Conversation
ronso0
force-pushed
the
effectchain-tooltip
branch
from
f2b3f24
to
483c54b
Compare
| populateMenu(); | ||
| } | ||
|
|
||
| void WEffectChainPresetButton::populateMenu() { | ||
| m_pMenu->clear(); | ||
|
|
||
| // Chain preset items | ||
| const auto bem = m_pEffectsManager->getBackendManager(); |
There was a problem hiding this comment.
| const auto bem = m_pEffectsManager->getBackendManager(); | |
| const auto* pBem = m_pEffectsManager->getBackendManager(); |
There was a problem hiding this comment.
Else the pointer is const, not the object it is pointing to.
Below the same.
There was a problem hiding this comment.
This returns EffectsBackendManagerPointer, I don't understand how EffectsBackendManager could be const here.
Now it's explicit const EffectsBackendManagerPointer instead of const auto.
There was a problem hiding this comment.
Oh, yes I missed that. Thank you.
| tooltip.append(bem->getDisplayNameForEffectPreset(pEffectPreset)); | ||
| } | ||
| } | ||
| QAction* pAction(new QAction(title, this)); |
There was a problem hiding this comment.
Can this become a parented_ptr?
|
Thank you for this nice addition. |
ronso0
force-pushed
the
effectchain-tooltip
branch
from
483c54b
to
3405e10
Compare
|
@daschuer please resolve your review. |
|
We have the issue that Chains with a single effect are looking wrong, like this: Filter Can we use the pManifest->setDescription() instead? Filter Or just skip the bold headline? |
|
or just show
|
|
Single Bold Filter works for me. |
picking another low-hanging fruit to polish the new effects frontend:
show chained effects in tooltip of
Close #10605