Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deere: fix skin/library layout (library missing in default view with Qt6) #11912

Merged
merged 1 commit into from Sep 3, 2023

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Sep 3, 2023

I simply adopted the layout from LateNight.
@uklotzde Please test.

For me the entire library container was non-existant, i.e. in the splitter the waveforms container expanded to push the decks (+ fx + samplers) to the bottom.

@github-actions github-actions bot added the skins label Sep 3, 2023
Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 Fixes #11897

@ronso0 ronso0 linked an issue Sep 3, 2023 that may be closed by this pull request
@ronso0
Copy link
Member Author

ronso0 commented Sep 3, 2023

Great.
Fix confrmed by two users, waiting for CI, then I'll merge this myself.

@ronso0 ronso0 merged commit e52080b into mixxxdj:2.4 Sep 3, 2023
13 checks passed
@ronso0 ronso0 deleted the deere-qt6-fix-missing-library branch September 3, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Qt6/Deere: No library view
2 participants