CMakeLists: Default QT6 to ON
#11934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swiftb0y
approved these changes
Sep 7, 2023
No. |
Holzhaus
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that
was recently merged and that the 2.5 vcpkg environments now ship Qt 6, we should set
-DQT6=ONby default, both for consistency and to eliminate another configuration gotcha. This should also remove the need to set this explicitly in CI (though I didn't remove those here to keep the PR focused and since the workflows might be intentionally explicit).Of course, developers can still set
-DQT6=OFFto build with Qt 5.