Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mixxx::audio::ChannelCount type instead of int/unsigned char/etc. #11941

Merged
merged 7 commits into from Sep 9, 2023

Conversation

Holzhaus
Copy link
Member

@Holzhaus Holzhaus commented Sep 8, 2023

No description provided.

@Holzhaus Holzhaus added this to In Progress in Semanting Type Refactoring via automation Sep 8, 2023
@github-actions github-actions bot added the ui label Sep 8, 2023
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I fear in the future ChannelCount won't be a powerful enough abstraction anymore, for stems we probably need a ChannelLayout that can manage an arbitrary amount of channels and give them meaning (surround sound, stems, etc?).

@Swiftb0y Swiftb0y merged commit 1fce230 into mixxxdj:main Sep 9, 2023
13 checks passed
Semanting Type Refactoring automation moved this from In Progress to Done Sep 9, 2023
@Holzhaus
Copy link
Member Author

Holzhaus commented Sep 9, 2023

I fear in the future ChannelCount won't be a powerful enough abstraction anymore, for stems we probably need a ChannelLayout that can manage an arbitrary amount of channels and give them meaning (surround sound, stems, etc?).

We already have:

mixxx/src/audio/types.h

Lines 26 to 31 in 1fce230

enum class ChannelLayout {
Mono, // 1 channel
DualMono, // 2 channels with identical signals
Stereo, // 2 independent channels left/right
// ...to be continued...
};

We could start replacing ChannelCount instances with it (where applicable).

@Swiftb0y
Copy link
Member

Ah didn't know about that. Yeah makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants