Fix crash when no GL context is available #11963
Conversation
…when double click right one the waveforms.
|
I guess this should be targeted to 2.4? |
src/mixxxmainwindow.cpp
Outdated
| // note: the format is set in the WGLWidget's OpenGLWindow constructor | ||
| return; |
There was a problem hiding this comment.
this comment no longer applies since the context has been created earlier in the function
ronso0
changed the title
src/mixxxmainwindow.cpp
Outdated
| initialize(); | ||
| #endif | ||
| QSurfaceFormat format; | ||
| format.setVersion(2, 1); |
There was a problem hiding this comment.
Without this, we had a single place where QSurfaceFormat was set (in OpenGLWindow constructor). Also, I liked going through an actual QOpenGLWindow creation to do the check. But I am okay with this change, especially because I agree with the eventual removal of the initial widget.
There was a problem hiding this comment.
We may consider to set the default format in a single place instead. But I was not sure about the implications.
There was a problem hiding this comment.
should be easy enough to solve by just putting the QSurfaceFormat creation into a function that is called from both places, right?
… have all GL configurations in one place.
|
Done. |
This fixes #11929
A next iteration would be to get rid of the initial GL widget. Maybe we can already use the context without the widget.
I am just afraid that this requires a lot of testing. Nothing suitable just before a release.