New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skins: Fix checkbox styling on Qt 6 #12050
Conversation
Does the ring occur with all Qt6 builds (updated QtSvg version) or only this branch? Re this fix: Qt stylesheets, especially partially overriding default styles is still a mystery after all... |
It occurs with all Qt6 builds on my Windows11 system! |
Alright, I'll take a look and try to tweak some LateNight controls when I'm back. |
Any update on this? Is the ring issue related to this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes it for me!
Since it occurs on all qt6 builds (not just this branch) then that's an unrelated issue we should fix separately -- can you file a new issue for that? |
(in general I am not involved enough with day-to-day mixxx to merge pull requests, so maybe @daschuer you can do that if it looks good to you?) |
On Linux with Qt 6.2.3 this fixes that unchecked unselected checkbox icons aren't rendered at all. |
Fixes #11630, fixes #11908
This fixes the UI regression that the BPM lock and play count checkboxes are rendered twice when building with Qt 6:
Seems to solve the issue under all skins and I couldn't notice any other UI regressions. Perhaps someone could test the Qt 5 build too, just to make sure that this doesn't break anything there?
cc @ronso0