Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skins: Fix checkbox styling on Qt 6 #12050

Merged
merged 1 commit into from Nov 7, 2023

Conversation

fwcd
Copy link
Member

@fwcd fwcd commented Oct 1, 2023

Fixes #11630, fixes #11908

This fixes the UI regression that the BPM lock and play count checkboxes are rendered twice when building with Qt 6:

Before After
Screenshot 2023-10-01 at 16 28 15 Screenshot 2023-10-01 at 16 28 04

Seems to solve the issue under all skins and I couldn't notice any other UI regressions. Perhaps someone could test the Qt 5 build too, just to make sure that this doesn't break anything there?

cc @ronso0

@github-actions github-actions bot added the skins label Oct 1, 2023
@JoergAtGithub
Copy link
Member

Looks correct on Windows now. Note, that there is also an additional light grey border/ring on the gain knobs:
grafik
For reference a Mixxx 2.4 Qt5 build:
grafik

@ronso0
Copy link
Member

ronso0 commented Oct 3, 2023

Does the ring occur with all Qt6 builds (updated QtSvg version) or only this branch?

Re this fix: Qt stylesheets, especially partially overriding default styles is still a mystery after all...
[jack in the box emoji]

@JoergAtGithub
Copy link
Member

Does the ring occur with all Qt6 builds (updated QtSvg version) or only this branch?

It occurs with all Qt6 builds on my Windows11 system!

@ronso0
Copy link
Member

ronso0 commented Oct 3, 2023

Alright, I'll take a look and try to tweak some LateNight controls when I'm back.
With Qt5 some Svg effects (translucent gradients) where not rendered at all or produced weird glitches.

@fwcd
Copy link
Member Author

fwcd commented Oct 13, 2023

Any update on this? Is the ring issue related to this?

Copy link
Member

@ywwg ywwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes it for me!

@ywwg
Copy link
Member

ywwg commented Nov 6, 2023

It occurs with all Qt6 builds on my Windows11 system!

Since it occurs on all qt6 builds (not just this branch) then that's an unrelated issue we should fix separately -- can you file a new issue for that?

@ywwg
Copy link
Member

ywwg commented Nov 6, 2023

(in general I am not involved enough with day-to-day mixxx to merge pull requests, so maybe @daschuer you can do that if it looks good to you?)

@ronso0
Copy link
Member

ronso0 commented Nov 7, 2023

On Linux with Qt 6.2.3 this fixes that unchecked unselected checkbox icons aren't rendered at all.
Don't notice regressions with Qt 5.12.8
LGTM, thanks!

@ronso0 ronso0 merged commit 30bca40 into mixxxdj:main Nov 7, 2023
13 checks passed
@ronso0 ronso0 added the QT6 label Nov 30, 2023
@fwcd fwcd deleted the fix-checkbox-styling-qt6 branch December 10, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Qt6/Deere: Played checkmark is rendered twice bpm lock icon rendered incorrectly on QT6 (no QML)
4 participants