Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

privat generated ui headers #12060

Merged
merged 5 commits into from Nov 1, 2023
Merged

privat generated ui headers #12060

merged 5 commits into from Nov 1, 2023

Commits on Oct 28, 2023

  1. Remove unused QmlApplication::m_pDlgPreferences

    @daschuer
    daschuer committed Oct 28, 2023
    Copy the full SHA
    ed5bb34 View commit details
    Browse the repository at this point in the history

  2. Make DlgPreferences in CoreServices and return a generic QDialog. 

    This hides implementation details from the mixxx-qml-lib
    @daschuer
    daschuer committed Oct 28, 2023
    Copy the full SHA
    f1479ec View commit details
    Browse the repository at this point in the history

  3. Remove "ugly hack" including generated files from a different library

    @daschuer
    daschuer committed Oct 28, 2023
    Copy the full SHA
    980ef7f View commit details
    Browse the repository at this point in the history

  4. Remove dlgpreferences.h include

    @daschuer
    daschuer committed Oct 28, 2023
    Copy the full SHA
    3a0603a View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. Add a comment about upcast in makeDlgPreferences()

    @daschuer
    daschuer committed Oct 30, 2023
    Copy the full SHA
    a106ae7 View commit details
    Browse the repository at this point in the history